Skip to content

Fix printing of types for imported functions #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fix printing of types for imported functions #5927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72db72e
Fix printing of types for imported functions
tlively Sep 9, 2023
2407ab7
update more tests
tlively Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/passes/Print.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2846,7 +2846,7 @@ void PrintSExpression::visitImportedFunction(Function* curr) {
lastPrintedLocation = {0, 0, 0};
o << '(';
emitImportHeader(curr);
handleSignature(curr->getSig(), curr->name);
handleSignature(curr->type, curr->name);
o << ')';
o << maybeNewLine;
}
Expand Down
2 changes: 1 addition & 1 deletion test/lit/passes/signature-pruning.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@

;; As above, but now an import also uses this signature, which prevents us
;; from changing anything.
;; CHECK: (import "out" "func" (func $import (type $func.0) (param i32)))
;; CHECK: (import "out" "func" (func $import (type $sig) (param i32)))
(import "out" "func" (func $import (type $sig) (param i32)))

(memory 1 1)
Expand Down
2 changes: 1 addition & 1 deletion test/lit/passes/signature-refining.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@

;; CHECK: (type $8 (func (param funcref) (result (ref $C))))

;; CHECK: (import "binaryen-intrinsics" "call.without.effects" (func $no.side.effects (type $func.0) (param funcref) (result (ref null $A))))
;; CHECK: (import "binaryen-intrinsics" "call.without.effects" (func $no.side.effects (type $6) (param funcref) (result (ref null $A))))
(import "binaryen-intrinsics" "call.without.effects" (func $no.side.effects
(param funcref)
(result (ref null $A))
Expand Down
2 changes: 1 addition & 1 deletion test/lit/wat-kitchen-sink.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@

;; CHECK: (import "mod" "" (global $gimport$1 (ref null $many)))

;; CHECK: (import "mod" "f5" (func $fimport$1 (type $func.0)))
;; CHECK: (import "mod" "f5" (func $fimport$1 (type $void)))

;; CHECK: (global $2 (mut i32) (i32.const 0))

Expand Down