-
Notifications
You must be signed in to change notification settings - Fork 825
Use standard GC encodings by default #5873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The legacy encodings remain available for now by defining USE_LEGACY_GC_ENCODINGS at build time.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This is meant to be landed immediately after the GC proposal goes to phase 4. A vote to promote it to phase 4 is currently scheduled for September 12. |
Codecov Report
@@ Coverage Diff @@
## main #5873 +/- ##
==========================================
- Coverage 42.46% 42.46% -0.01%
==========================================
Files 482 482
Lines 74727 74726 -1
Branches 11929 11932 +3
==========================================
- Hits 31732 31729 -3
Misses 39790 39790
- Partials 3205 3207 +2
|
|
Please also make a new release after the merge. |
|
@bashor, we will make a release by the end of the week, if that's ok for you. It would be good to get as many text format cleanups into the release as possible. |
|
@tlively, it would be nice to have a release as soon as possible since binaryen is one of the dependencies we need to update. We don't use binaryen's text format support. |
|
@tlively any news? |
|
I've just created the release now. CI is currently working on producing the build artifacts for it. |
|
Great! Thanks a lot! |
The legacy encodings remain available for now by defining USE_LEGACY_GC_ENCODINGS at build time.

The legacy encodings remain available for now by defining
USE_LEGACY_GC_ENCODINGS at build time.