Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Aug 10, 2023

The legacy encodings remain available for now by defining
USE_LEGACY_GC_ENCODINGS at build time.

The legacy encodings remain available for now by defining
USE_LEGACY_GC_ENCODINGS at build time.
@tlively tlively requested a review from kripken August 10, 2023 20:59
@tlively
Copy link
Member Author

tlively commented Aug 10, 2023

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlively and the rest of your teammates on Graphite Graphite

@tlively
Copy link
Member Author

tlively commented Aug 10, 2023

This is meant to be landed immediately after the GC proposal goes to phase 4. A vote to promote it to phase 4 is currently scheduled for September 12.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5873 (5878f44) into main (616c08b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5873      +/-   ##
==========================================
- Coverage   42.46%   42.46%   -0.01%     
==========================================
  Files         482      482              
  Lines       74727    74726       -1     
  Branches    11929    11932       +3     
==========================================
- Hits        31732    31729       -3     
  Misses      39790    39790              
- Partials     3205     3207       +2     
Files Changed Coverage Δ
src/wasm-binary.h 83.60% <ø> (ø)

... and 5 files with indirect coverage changes

@bashor
Copy link

bashor commented Aug 29, 2023

Please also make a new release after the merge.

@tlively tlively merged commit 38559bf into main Sep 12, 2023
@tlively tlively deleted the default-gc-standard-opcodes branch September 12, 2023 21:05
@tlively
Copy link
Member Author

tlively commented Sep 12, 2023

@bashor, we will make a release by the end of the week, if that's ok for you. It would be good to get as many text format cleanups into the release as possible.

@bashor
Copy link

bashor commented Sep 13, 2023

@tlively, it would be nice to have a release as soon as possible since binaryen is one of the dependencies we need to update. We don't use binaryen's text format support.

@bashor
Copy link

bashor commented Sep 14, 2023

@tlively any news?

@tlively
Copy link
Member Author

tlively commented Sep 14, 2023

I've just created the release now. CI is currently working on producing the build artifacts for it.

@bashor
Copy link

bashor commented Sep 14, 2023

Great! Thanks a lot!

radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
The legacy encodings remain available for now by defining
USE_LEGACY_GC_ENCODINGS at build time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants