Skip to content

Revert some changes from #3193 #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

MaxGraey
Copy link
Contributor

@MaxGraey MaxGraey commented Oct 6, 2020

Fuzzed found (seed 17400736677355043573) invalid transform which introduced in #3193.

(signed)x % (i32|i64).min_s ==> (x & (i32|i64).max_s)

This not valid without equal / unequal with zero unfortunately. So this PR fix that.

cc @tlively

@MaxGraey MaxGraey changed the title Revert some changes for #3193 Revert some changes from #3193 Oct 6, 2020
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tlively tlively merged commit fe56186 into WebAssembly:master Oct 6, 2020
@MaxGraey MaxGraey deleted the fix-3153 branch October 6, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants