Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asyncify: Instrument indirect calls from functions in add-list or only-list #2913
Asyncify: Instrument indirect calls from functions in add-list or only-list #2913
Changes from 6 commits
104ed27
9f30d54
831fa36
46fa503
aa3a585
78c821c
7dce992
088088e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this logic could be combined with the
return
below to be just one return statement. I think this might be simpler than the the current code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you suggesting they be combined?
I guess 738 could be
return true
. Or the 4 lines could bereturn walker.canChangeState || (walker.hasIndirectCall && (canIndirectChangeState || map[func].addedFromList))
. But both seem less good to me?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the latter, but I think the former would also be an improvement. I just prefer to have to track less state and control flow. But this is very much a nit, so I leave it to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to explain why I prefer it as it is, combined with the lines above, this overall code has the form
Actually re-reading it now, those two exceptions are in the wrong order anyhow, so this is moot... reordering, and then the condition before the return is very small so I agree it can be merged with the return, doing it that way.