Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sessionId saving in createSession() successful result. #15

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

grvgoel81
Copy link
Collaborator

@grvgoel81 grvgoel81 commented Sep 20, 2024

Motivation and Context

  • Removed sessionId saving in createSession() successful result.
  • Update session-manager as per swift and web.

Jira Link: https://toruslabs.atlassian.net/browse/PD-4095

Description

  • Removed sessionId saving in createSession() successful result as pnp sdk needs to save sessionId in setResultUrl mthod and sfa sdk saves after createSession API success.
  • Update session-manager as per swift and web.

How has this been tested?

  • By running test cases.

Screenshots (if appropriate):

Screenshot 2024-09-20 at 9 38 17 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

grvgoel81 and others added 10 commits September 20, 2024 09:34
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81 grvgoel81 changed the title Added saveSessionFlag in createSession API. Removed sessionId saving in createSession() successful result. Sep 25, 2024
grvgoel81 and others added 3 commits October 30, 2024 09:22
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Signed-off-by: Gaurav Goel <gaurav@tor.us>
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit dc0c3c5 into master Nov 6, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/updates-in-createSession branch November 6, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants