Skip to content

Conversation

@Satoshi-Sh
Copy link
Member

Web Dev Path
238

Have you updated the CHANGELOG.md file? If not, please do it.

Yes

What is this change?

  • CSS moduels migration for Nav
  • Fixed active state bug on navigation. When the window width pass the desktop breaking point, the active state should be turned to false.
Screenshot from 2025-08-16 21-32-35

How to replicate the issue?

On prod or main branch, press the hamburger menu on the narrow window and then make the window wider.

If necessary, please describe how to test the new feature or fix.

Please check the navigation styling behavior.

When should this be merged?

After reviews

@Satoshi-Sh Satoshi-Sh requested a review from a team August 17, 2025 02:41
@Satoshi-Sh Satoshi-Sh self-assigned this Aug 17, 2025
@netlify
Copy link

netlify bot commented Aug 17, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit 25e66bb
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/68a14140ac31bb0008693f2a
😎 Deploy Preview https://deploy-preview-276--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@briangesteban briangesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix @Satoshi-Sh!

Copy link
Member

@oluwatobiss oluwatobiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for fixing the active nav bug, @Satoshi-Sh!

@cherylli cherylli self-requested a review August 19, 2025 10:41
@Satoshi-Sh Satoshi-Sh merged commit 405b807 into main Aug 19, 2025
4 checks passed
@Satoshi-Sh Satoshi-Sh deleted the refactor/to-scss-Nav branch August 19, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants