remove dependency on storify for controllers/user.py #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update tests to reflect changes to login.py and resetpassword.py
|
This pull request introduces 2 alerts when merging 823fb76 into f277273 - view on LGTM.com new alerts:
|
kfkitsune
suggested changes
Aug 23, 2020
charmander
reviewed
Oct 1, 2020
Comment on lines
+245
to
+254
| login.create( | ||
| request.params.get('username', ''), | ||
| request.params.get('email', ''), | ||
| request.params.get('emailcheck', ''), | ||
| request.params.get('password', ''), | ||
| request.params.get('passcheck', ''), | ||
| request.params.get('year', ''), | ||
| request.params.get('month', ''), | ||
| request.params.get('day', '') | ||
| ) |
Contributor
There was a problem hiding this comment.
This one could benefit from some named argument safety:
Suggested change
| login.create( | |
| request.params.get('username', ''), | |
| request.params.get('email', ''), | |
| request.params.get('emailcheck', ''), | |
| request.params.get('password', ''), | |
| request.params.get('passcheck', ''), | |
| request.params.get('year', ''), | |
| request.params.get('month', ''), | |
| request.params.get('day', '') | |
| ) | |
| login.create( | |
| username=request.params.get('username', ''), | |
| email=request.params.get('email', ''), | |
| emailcheck=request.params.get('emailcheck', ''), | |
| password=request.params.get('password', ''), | |
| passcheck=request.params.get('passcheck', ''), | |
| year=request.params.get('year', ''), | |
| month=request.params.get('month', ''), | |
| day=request.params.get('day', ''), | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #744