Remove storify from controllers/settings.py #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfkitsune
reviewed
Aug 20, 2020
| return Response(define.webpage(request.userid, "control/edit_profile.html", [form, form], title="Edit Profile", options=["typeahead"])) | ||
| sites = zip(site_names, site_values) | ||
|
|
||
| if 'more' in request.params: |
Member
There was a problem hiding this comment.
Suggested change
| if 'more' in request.params: | |
| # Allow adding additional links to the profile via 'New' button without intermediate save if JavaScript is disabled | |
| if 'more' in request.params: |
The only comment I have here is we might consider a comment here... it took me way too long to grok the code and realize that this more parameter typically isn't present; it only is if scripts are off, for adding new links without actually saving in-between each newly added entry until done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split from #744