-
-
Notifications
You must be signed in to change notification settings - Fork 35
remove dependency on storify from controllers/general.py #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency on storify from controllers/general.py #797
Conversation
+ adjustments as recommended in code review
| "submit": search.browse(request.userid, rating, 22, form, find="submit"), | ||
| "char": search.browse(request.userid, rating, 22, form, find="char"), | ||
| "journal": search.browse(request.userid, rating, 22, form, find="journal"), | ||
| "submit": search.browse(request.userid, rating, 22, "submit", cat, backid, nextid), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could benefit from named arguments, and backid/nextid being parsed in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what you were thinking? https://github.com/sl1-1/weasyl/tree/remove-storify-from-controllers-general
Not sure if there is a way to change a pullrequest, or if you should pull the changes to your branch? :)
kfkitsune
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as far as I can ascertain!
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
=========================================
Coverage ? 67.70%
=========================================
Files ? 157
Lines ? 12474
Branches ? 0
=========================================
Hits ? 8446
Misses ? 4028
Partials ? 0
Continue to review full report at Codecov.
|
Single rebased commit from #744.