Skip to content

Conversation

@charmander
Copy link
Contributor

@charmander charmander commented Apr 26, 2020

  • adjustments as recommended in code review

Single rebased commit from #744.

+ adjustments as recommended in code review
"submit": search.browse(request.userid, rating, 22, form, find="submit"),
"char": search.browse(request.userid, rating, 22, form, find="char"),
"journal": search.browse(request.userid, rating, 22, form, find="journal"),
"submit": search.browse(request.userid, rating, 22, "submit", cat, backid, nextid),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could benefit from named arguments, and backid/nextid being parsed in advance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what you were thinking? https://github.com/sl1-1/weasyl/tree/remove-storify-from-controllers-general
Not sure if there is a way to change a pullrequest, or if you should pull the changes to your branch? :)

Copy link
Member

@kfkitsune kfkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as far as I can ascertain!

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8057229). Click here to learn what that means.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #797   +/-   ##
=========================================
  Coverage          ?   67.70%           
=========================================
  Files             ?      157           
  Lines             ?    12474           
  Branches          ?        0           
=========================================
  Hits              ?     8446           
  Misses            ?     4028           
  Partials          ?        0           
Impacted Files Coverage Δ
weasyl/controllers/general.py 47.36% <0.00%> (ø)
weasyl/search.py 80.74% <20.00%> (ø)
weasyl/banner.py 37.50% <0.00%> (ø)
weasyl/test/test_folders.py 100.00% <0.00%> (ø)
weasyl/controllers/detail.py 50.58% <0.00%> (ø)
weasyl/test/useralias/test_set.py 100.00% <0.00%> (ø)
weasyl/controllers/interaction.py 31.40% <0.00%> (ø)
weasyl/controllers/routes.py 100.00% <0.00%> (ø)
libweasyl/libweasyl/models/helpers.py 64.32% <0.00%> (ø)
weasyl/macro.py 77.77% <0.00%> (ø)
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057229...e140585. Read the comment docs.

@charmander charmander closed this Aug 19, 2020
@charmander charmander deleted the remove-storify-from-controllers-general branch August 19, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants