Fix tall banners breaking layout #1074
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, the bug might be that the banner isn’t resized by the backend. Need to check what’s promised by the settings text and the code. |
Codecov Report
@@ Coverage Diff @@
## master #1074 +/- ##
=======================================
Coverage 58.09% 58.09%
=======================================
Files 96 96
Lines 9157 9157
Branches 1647 1647
=======================================
Hits 5320 5320
Misses 3416 3416
Partials 421 421 Continue to review full report at Codecov.
|
Contributor
Author
|
Also… did insufficiently wide banners used to be stretched? Because that seems like the right behaviour, and they aren’t now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.