Skip to content
This repository was archived by the owner on Dec 29, 2024. It is now read-only.

Registry indexing, function calls, global manipulation, now all recursive! #156

Merged
merged 66 commits into from
Sep 13, 2023
Merged

Registry indexing, function calls, global manipulation, now all recursive! #156

merged 66 commits into from
Sep 13, 2023

Conversation

radiantgurl
Copy link
Contributor

@radiantgurl radiantgurl commented Sep 12, 2023 •
edited
Loading

Some nice QoL features

@radiantgurl
Add get/set registry
4d48a2a
@radiantgurl
Add to _bind_methods
2a7107c
@radiantgurl
add get/set registry to luaState.h
0933b12
@radiantgurl
Implement set/get registry
afbf4c2
@radiantgurl
Style fix
8b8057d
@radiantgurl
Update luaAPI.cpp
a1e8cf5
@radiantgurl
Update luaState.cpp
1c9acaa
@radiantgurl
Add entries for function related methods in the registry.
da451dd
@radiantgurl
Implement function registry methods to lua state
5b459e5
@radiantgurl
Add function registry related methods
bc88974
@radiantgurl
Implement registry function calls
7d2c382
@radiantgurl
these bugs ;-;
e0a6c23
@radiantgurl
brain fart
a324f23 
lmao
@radiantgurl
Add registry docs
050acc6
@radiantgurl
Add headers for registry methods
f8b2b28
@radiantgurl
Implement registry methods.
ef0b299
@radiantgurl
Merge pull request #1 from RadiantUwU/main
4d2e757 
thankies :333
@radiantgurl
Update coroutine docs for registry functions.
c90a516
@radiantgurl
Add shtuff
5d5fe18
@radiantgurl
im a dum dum
37498d7
@radiantgurl
Merge pull request #2 from RadiantUwU/editing
71ded41 
Add the table indexing stuff
@radiantgurl
style fix
56c2e36
@radiantgurl
bug fix
b4184e8
@radiantgurl
Make LuaJIT work
b790d9b
@radiantgurl
Make GDExtension work
2e9b5ca
@radiantgurl
style fix
f5c46e9
@radiantgurl
i forgot how c++ works
ec3a9a7
@radiantgurl
copy pasting was a bad idea
bff82fb
@radiantgurl
gdextension always breaks stuff :c
930e4e0
@radiantgurl radiantgurl marked this pull request as ready for review September 12, 2023 14:26
@radiantgurl radiantgurl requested a review from Trey2k September 13, 2023 18:16
Trey2k
Trey2k suggested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Trey2k Trey2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues still, after these are resolved it should be good for to be merged.

@radiantgurl radiantgurl requested a review from Trey2k September 13, 2023 18:35
@radiantgurl
Copy link
Contributor Author

fixed issues

Trey2k
Trey2k reviewed Sep 13, 2023
View reviewed changes
@radiantgurl radiantgurl requested a review from Trey2k September 13, 2023 18:42
Trey2k
Trey2k approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Trey2k Trey2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming checks pass we should be good. Thanks!

@radiantgurl
Copy link
Contributor Author

uhoh

@radiantgurl
Copy link
Contributor Author

style fix

@Trey2k
Copy link
Member

Trey2k commented Sep 13, 2023

uhoh

Static checks can be picky

@radiantgurl
Copy link
Contributor Author

Oops, i went overboard with replacing

@radiantgurl
Copy link
Contributor Author

Should be fine... hopefully....

@radiantgurl
Copy link
Contributor Author

I think its gonna be fine

@Trey2k Trey2k merged commit ac5beb3 into WeaselGames:main Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Trey2k Trey2k Trey2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radiantgurl @Trey2k