Skip to content

Dev 1.15.0 code review fix#856

Merged
casionone merged 25 commits intodev-1.15.0-webankfrom
dev-1.15.0-code-review-fix
Aug 29, 2025
Merged

Dev 1.15.0 code review fix#856
casionone merged 25 commits intodev-1.15.0-webankfrom
dev-1.15.0-code-review-fix

Conversation

@v-kkhuang
Copy link

What is the purpose of the change

EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.

Related issues/PRs

Related issues: close #590 close #591
Related pr:#591

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

Copy link

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM。

@casionone casionone merged commit fc11506 into dev-1.15.0-webank Aug 29, 2025
12 of 16 checks passed
aiceflower pushed a commit that referenced this pull request Oct 15, 2025
* Code optimization

* Code optimization

* Code optimization

* Security order repair

* 修复诊断异常

* Code optimization

* add  shell executor conf

* aisql  support  mcp

* fix linkis client login error

* Revert "add  shell executor conf"

This reverts commit af6c1dc.

* bug fix

* code optimization

* code optimization

* code optimization

* code optimization

* code review fix

---------

Co-authored-by: “v_kkhuang” <“420895376@qq.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants