feat/ERC721 permit

[leonardishere]

#88 #155

Use this in the frontend to generate signatures

NonFungibleTime/packages/contracts/test/utilities/getErc721PermitSignature.ts

Lines 7 to 14 in 03e291d

	export async function getErc721PermitSignature(
	owner: SignerWithAddress,
	nftContract: Contract,
	spender: string,
	tokenID: BigNumberish,
	deadline: BigNumberish = constants.MaxUint256,
	nonce: BigNumberish = constants.MaxUint256 // optional override. leave empty to use correct nonce
	): Promise<Signature> {

[netlify]

✔️ Deploy Preview for elated-kalam-a67780 ready!

🔨 Explore the source changes: ea6c7a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-kalam-a67780/deploys/620cee54cb13cd0008375374

😎 Browse the preview: https://deploy-preview-161--elated-kalam-a67780.netlify.app

[defispartan]

So I had a bit of a misunderstanding on the contracts side 😓 , I thought approve/permit was required for all NFTs transfers but safeTransferFrom allows the owner to transfer without approval.

What kind of uses cases would this enable @leonardishere? And does it still make sense to add this if we aren't going to directly use this on our frontend?

Setting up a gasless secondary market is what came to mind for me, but I'm not sure that we need to support this since there would be no royalty generated from these transactions

[leonardishere]

So I had a bit of a misunderstanding on the contracts side sweat , I thought approve/permit was required for all NFTs transfers but safeTransferFrom allows the owner to transfer without approval.

What kind of uses cases would this enable @leonardishere? And does it still make sense to add this if we aren't going to directly use this on our frontend?

Setting up a gasless secondary market is what came to mind for me, but I'm not sure that we need to support this since there would be no royalty generated from these transactions

It's simply an ERC721 equivalent of https://eips.ethereum.org/EIPS/eip-2612. Someone else could give a better write up of its benefits but secondary markets would probably get the most benefit. I haven't checked the gas costs for the added functionality but it shouldn't be too crazy.