Skip to content

Unbreak build on FreeBSD #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2023
Merged

Unbreak build on FreeBSD #188

merged 2 commits into from
Oct 7, 2023

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Oct 7, 2023

No description provided.

jbeich added 2 commits October 7, 2023 13:33
@jbeich
notifications: use glib type of unsigned long after bad121a
9ba0497 
src/panel/widgets/notifications/notification-info.cpp:54:5: error: unknown type name 'ulong'
    ulong pixel_size = (channels * bits_per_sample + 7) / 8;
    ^
src/panel/widgets/notifications/notification-info.cpp:55:40: error: expected ')'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                       ^
src/panel/widgets/notifications/notification-info.cpp:55:32: note: to match this '('
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                               ^
src/panel/widgets/notifications/notification-info.cpp:55:34: error: use of undeclared identifier 'ulong'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                 ^
src/panel/widgets/notifications/notification-info.cpp:55:55: error: use of undeclared identifier 'ulong'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                                      ^
src/panel/widgets/notifications/notification-info.cpp:55:61: error: expected ')'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                                            ^
src/panel/widgets/notifications/notification-info.cpp:55:8: note: to match this '('
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
       ^
@jbeich
command-output: add missing header for libc++ 14 after ff9f791
5cafdab 
src/panel/widgets/command-output.cpp:25:30: error: implicit instantiation of undefined template 'std::array<char, 16>'
        std::array<char, 16> buffer;
                             ^
/usr/include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
ammen99
ammen99 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) I'll add those to the 0.8.0 release as well ..

@ammen99 ammen99 merged commit ac8cdd2 into WayfireWM:master Oct 7, 2023
ammen99 pushed a commit that referenced this pull request Oct 7, 2023
@jbeich @ammen99
Unbreak build on FreeBSD (#188)
65ae2ef 
* notifications: use glib type of unsigned long after bad121a

src/panel/widgets/notifications/notification-info.cpp:54:5: error: unknown type name 'ulong'
    ulong pixel_size = (channels * bits_per_sample + 7) / 8;
    ^
src/panel/widgets/notifications/notification-info.cpp:55:40: error: expected ')'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                       ^
src/panel/widgets/notifications/notification-info.cpp:55:32: note: to match this '('
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                               ^
src/panel/widgets/notifications/notification-info.cpp:55:34: error: use of undeclared identifier 'ulong'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                 ^
src/panel/widgets/notifications/notification-info.cpp:55:55: error: use of undeclared identifier 'ulong'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                                      ^
src/panel/widgets/notifications/notification-info.cpp:55:61: error: expected ')'
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
                                                            ^
src/panel/widgets/notifications/notification-info.cpp:55:8: note: to match this '('
    if (data_var.get_size() != ((ulong)height - 1) * (ulong)rowstride + (ulong)width * pixel_size)
       ^

* command-output: add missing header for libc++ 14 after ff9f791

src/panel/widgets/command-output.cpp:25:30: error: implicit instantiation of undefined template 'std::array<char, 16>'
        std::array<char, 16> buffer;
                             ^
/usr/include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbeich @ammen99