-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation time improvements (part 1) #2581
base: master
Are you sure you want to change the base?
Conversation
There is no need for this header at all.
Here on
|
Huh weird, maybe I need to test gcc too instead of just clang. In any case, try adding pch, maybe that will tilt the timing in favor of the changes? |
According to the meson docs, b_pch defaults to |
Part 1 of my changes aimed at improving compilation times in Wayfire.
The changes here are pretty straightforward, just shuffling header files and definitions around so that we don't include stuff we don't need.
There are no breaking changes for plugins, but some plugins may be broken if they rely on transitive includes.Breaking changes for plugins:
wf::get_core().config
is now a pointer.keyboard-focus-changed
andseat-activity
signals are defined in seat.hppIf plugins use these signals, they ought to now include the correct headers.
Benchmark on my 6C12T laptop shows 52s build time before, 46s build time after, so about 12% faster.