-
Notifications
You must be signed in to change notification settings - Fork 2
Included Licensing Decision Processes #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to include a decision process and an example for using code with restrictive licensing.
to include a decision process for choosing a license for a waylab repo.
d33bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thought your additions looked good and I liked the diagrams. Would it make sense to add an example LICENSE file for reference and evolution over time? This might make it easier for someone to reference quickly, for instance, when building a new project.
|
Thanks for mentioning the copyright suggestions @d33bs. Requesting a re-review after including those changes |
|
One thing I forgot to ask is do I need to include the |
I think it could be valuable although it may be better to just have github manage the license file creation and just mention the copyright line. Although, I could see either way. Given this alternative approach, what are your thoughts? |
d33bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing things @MattsonCam ! Regarding deferring to the GitHub license template: sounds good! Does this get mentioned anywhere in the playbook just yet? If not, consider adding it (in case someone doesn't already know that repos can be built like this).
One thing I forgot to ask is do I need to include the (c) like in this example?
I think it'd be a good idea to include it. My understanding is that this helps establish the starting year of the copyright claim which can be useful in understanding how the copyright might apply in specific scenarios. Without this it could be that the copyright starting year is more vague (or would have to be inferred from the git log date).
Sounds good, I hadn't thought of mentioning this, but I think it would help so I'll add it |
I'll also add this |
- Added the copyright sign - Provided a link to the CU Innovations page - Provided a link to guide license generation in a repo
|
Thanks for the follow-up @d33bs, requesting another re-review now |
|
Thanks @d33bs, for your help with this pr! Merging now |
This pr includes two decision processes:
I am thinking of changing the location of the updates made in
github_strategy.mdto a different section in the same file. Any constructive feedback is welcome when reviewing