Skip to content

Conversation

@MattsonCam
Copy link
Member

This pr includes two decision processes:

  1. Choosing a license for a repo
  2. How to include code under a restrictive license

I am thinking of changing the location of the updates made in github_strategy.md to a different section in the same file. Any constructive feedback is welcome when reviewing

Cameron Mattson added 3 commits February 3, 2025 17:14
to include a decision process and an example
for using code with restrictive licensing.
to include a decision process
for choosing a license for a waylab repo.
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thought your additions looked good and I liked the diagrams. Would it make sense to add an example LICENSE file for reference and evolution over time? This might make it easier for someone to reference quickly, for instance, when building a new project.

@MattsonCam
Copy link
Member Author

Thanks for mentioning the copyright suggestions @d33bs. Requesting a re-review after including those changes

@MattsonCam MattsonCam requested a review from d33bs February 4, 2025 20:14
@MattsonCam
Copy link
Member Author

One thing I forgot to ask is do I need to include the (c) like in this example?
Copyright (c) 2025

@MattsonCam
Copy link
Member Author

Nice job! Thought your additions looked good and I liked the diagrams. Would it make sense to add an example LICENSE file for reference and evolution over time? This might make it easier for someone to reference quickly, for instance, when building a new project.

I think it could be valuable although it may be better to just have github manage the license file creation and just mention the copyright line. Although, I could see either way. Given this alternative approach, what are your thoughts?

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing things @MattsonCam ! Regarding deferring to the GitHub license template: sounds good! Does this get mentioned anywhere in the playbook just yet? If not, consider adding it (in case someone doesn't already know that repos can be built like this).

One thing I forgot to ask is do I need to include the (c) like in this example?

I think it'd be a good idea to include it. My understanding is that this helps establish the starting year of the copyright claim which can be useful in understanding how the copyright might apply in specific scenarios. Without this it could be that the copyright starting year is more vague (or would have to be inferred from the git log date).

@MattsonCam
Copy link
Member Author

Regarding deferring to the GitHub license template: sounds good! Does this get mentioned anywhere in the playbook just yet? If not, consider adding it (in case someone doesn't already know that repos can be built like this).

Sounds good, I hadn't thought of mentioning this, but I think it would help so I'll add it

@MattsonCam
Copy link
Member Author

I think it'd be a good idea to include it. My understanding is that this helps establish the starting year of the copyright claim which can be useful in understanding how the copyright might apply in specific scenarios. Without this it could be that the copyright starting year is more vague (or would have to be inferred from the git log date).

I'll also add this

- Added the copyright sign
- Provided a link to the CU Innovations page
- Provided a link to guide license generation in a repo
@MattsonCam
Copy link
Member Author

Thanks for the follow-up @d33bs, requesting another re-review now

@MattsonCam MattsonCam requested a review from d33bs February 7, 2025 21:10
@MattsonCam
Copy link
Member Author

Thanks @d33bs, for your help with this pr! Merging now

@MattsonCam MattsonCam merged commit a79509e into main Feb 7, 2025
1 check passed
@MattsonCam MattsonCam deleted the license_flowchart branch February 7, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants