-
Notifications
You must be signed in to change notification settings - Fork 3
Minor tweaks to Sup Figure 8 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tweaks to Sup Figure 8 #59
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jenna-tomkinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I made a few minor comments regarding the supp figure for you to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few overall (probably more nit-pick) comments:
- I think the font size could be increased just a bit, but totally optional. I think panels B and C can be a bit harder to read.
- In Panel B, the different color greens for Zernike are a bit hard to distinguish, in my opinion, especially when there is overlap as compared to the blue hues in the AreaShape. I would recommend making the green hues more distinguishable.
- In Panel C, a very nitpicky comment is that the color palette clashes a bit given the new AreaShape and Zernike colors but they are still distinguishable. So it might be good to find less clashy colors or leave it, both work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these comments! Here are my replies:
- While on the small size, fonts look ok to me. We'll have to figure out a way to increase font size if a reviewer requests this, but otherwise it is ok. I actually think the axis labels of panel A are the most difficult to read, so I have updated these slightly in the next commit!
- Thanks for calling this out! I've updated the color scheme - I think this is much improved :)
- In addressing point 2, I think I've achieved an answer for point 3.
Merging this in after adding new commits, thanks again
| ggsave(output_sup_figure_subset, dpi = 500, height = 14, width = 14) | ||
|
|
||
| sup_fig_3_gg | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how does Rscript formatting work, and should there be two empty endlines at the bottom of the script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope! I have removed an extra empty cell in the .ipynb file. thanks for noting this!

I also needed to adjust the data processing to account for updated input data types.
Supplementary Figure 8