-
Notifications
You must be signed in to change notification settings - Fork 3
Add Figure 1 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Figure 1 #57
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
It's a really nice figure! 🎉 Here are a couple nitpicks: Panel A
Panel B
General
Happy to give this another look after the second iteration! |
|
Here is what I have implemented based on your review: Panel A
Panel B (likely will need font increased)
GeneralMade the tags much bigger and fixed the alignment issue/whitespace issue by making the plot "free" per the documentation to avoid patchwork from trying to align itself. I look forward to more improvements after your next review! |
|
More nitpicks: Panel A
Panel B
|
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Jenna! Happy to review again for a round 3, but I will go ahead and approve so you can merge when you're happy.
Before merging, please also add this figure to the README in this PR - it is a great representation of our project which we want to highlight :)
|
@gwaybio Thank you lots for the review! This was a great first exercise with patchwork and I am excited to work more on creating figures! I will be merging now after addressing your comments, but please feel free to let me know if anything else needs to be updated. |

Add Figure 1
In this PR, figure 1 for the manuscript has been created in R using patchwork. Panel A is generated in the notebook, and Panel B is created in BioRender and saved as PNG.