Add JUMP analysis figure #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jenna-tomkinson
approved these changes
Mar 7, 2024
Member
jenna-tomkinson
left a comment
jenna-tomkinson
left a comment
There was a problem hiding this comment.
LGTM! I made some small comments for you to address, but feel free to merge after 😄
Member
There was a problem hiding this comment.
Clean and simple figure! Only nit-pick comment is that panel A has a bit more whitespace than panel B, especially on the left side. Might consider trying to reduce the whitespace more if possible.
Member
There was a problem hiding this comment.
Some comments:
- What is the difference between panels B and C? Is it that the B is the final model and C is shuffled? I can see they both focus only on compound perturbation which makes since as other perturbations did not show much enrichment at all.
- The y-axis titles are very close to the panel letters. Maybe it would work if the top plot for each panel could be moved in alignment with panel A, which might help with the whitespace.
Member
Author
There was a problem hiding this comment.
This is great feedback!
B and C have to do with time points. I add a ggtitle() to make this more clear.
I've updated the y axis titles and have moved panel A alignment closer to the label.
Member
Author
Updated figure 5
Updated sup fig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.