Restructure pr curves notebook #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* finish download module changes * download notebook * rerun split data module * rerun download module * rerun train_model * rerun evaluation module * rerun interpretation module * combine datasets * combine datasets * split changes * update format * format update * format * finish split data * combine datasets, remove holdout * formatting * rerun pipelines * remove folded class * rerun pipeline * Update utils/download_utils.py Co-authored-by: Dave Bunten <ekgto445@gmail.com> * PR fixes * module docstrings Co-authored-by: Dave Bunten <ekgto445@gmail.com>
d33bs
approved these changes
Feb 17, 2023
Member
d33bs
left a comment
d33bs
left a comment
There was a problem hiding this comment.
Nice work! I left a few suggestions but didn't see anything that would prevent a merge as-is.
One follow up I wasn't sure about:
- I noticed your mention about using one
.tsvbut saw there were.pngimages which were also removed. Should these images be replaced by anything new?
Member
Author
|
Thanks for the review! These images should not be replaced by anything new. The format for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review!
In this PR, the class PR curves notebook is restructured to follow the structure of the evaluate notebooks.
This means all the models are evaluated on each data subset and the resulting data are saved in one compiled `.tsv. file.