-
Notifications
You must be signed in to change notification settings - Fork 3
Fix slice ordering and add new test data #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MattsonCam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @d33bs, good job! I didn't check the z-slice images, but I want to include an example in our GFF discord channel. Can you DM me on discord to lmk how I can apply these changes? I anticipate it will just be updating the version of nViz.
Co-authored-by: Cameron Mattson <92554334+MattsonCam@users.noreply.github.com>
…to fix-slice-ordering
|
Thanks @MattsonCam for the review! I'm going to merge this in after making some changes based on your comments. Afterwards, I'll plan to deploy a new release for |
|
Hi @MattsonCam - this fix is now deployed within |
Description
This PR fixes an issue where individual z-slice files referenced to create a composite are not sorted properly by their z-slice filename ordering specification.
Changes are made to the function which reads file-based data and also to the test data to help demonstrate that all z-slices are in order. We now simulate cell-like sphere images and labels within the test data.
Along the journey here I also found that Napari was crashing frequently during tests. I was able to resolve some of these crashes by using the
showparameter with "headless" (non-Napari window appearing) mode for views.Many thanks to @MattsonCam who helped uncover this bug.
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.