Skip to content

Fix Linux CI #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d33bs merged 3 commits into from
Jul 31, 2025
Merged

Fix Linux CI #50

d33bs merged 3 commits into from
Jul 31, 2025

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Jul 29, 2025 •
edited
Loading

Description

We're currently seeing long runtimes without completion for Linux CI in GitHub Actions. This PR seeks to fix this challenge.

I found that if I updated the dependencies through Linux that the CI appeared to be happier about things. As part of this I updated the Dockerfile for the project and related poethepoet task.

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review July 30, 2025 22:23
MikeLippincott
MikeLippincott approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wanted to check if there is a way to test for the opening of napari on a headless linux server? If not nbd! If yes - might be out of scope for this PR.

@d33bs
Copy link
Member Author

d33bs commented Jul 31, 2025

LGTM. Just wanted to check if there is a way to test for the opening of napari on a headless linux server? If not nbd! If yes - might be out of scope for this PR.

Thanks @MikeLippincott ! It's a great question. I don't think there's an easy way to accomplish this given the headless/displayless nature of GH Actions containers. It might be possible to upload screenshots but this too might be complex (we'd need to simulate the display in a way that the container could render a screenshot without having an actual screen to send to). Some of this already occurs with our CI configuration for Linux but it's fragile and makes me a bit cautious about pushing the limits here (we could get rate-limited by GH eventually). Just the same I'll file an issue to explore this at a later time.

@d33bs d33bs mentioned this pull request Jul 31, 2025
Open
@d33bs d33bs merged commit 715d57d into WayScience:main Jul 31, 2025
5 checks passed
@d33bs d33bs deleted the fix-linux-ci-tests branch July 31, 2025 22:33
MikeLippincott pushed a commit to MikeLippincott/nViz that referenced this pull request Sep 29, 2025
@d33bs @MikeLippincott
Fix Linux CI (WayScience#50)
0b22013 
* update dockerfile for uv

* update deps and fix pre-commit config

* update dockerfile and poe task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeLippincott MikeLippincott MikeLippincott approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d33bs @MikeLippincott