Update labels_dir parameter to include default
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33bs
approved these changes
Jan 31, 2025
Member
d33bs
left a comment
d33bs
left a comment
There was a problem hiding this comment.
Thanks @jenna-tomkinson ! This LGTM! I noticed there's a minor patch that's needed to pass the pre-commit check, otherwise squash + merge at will :) (should just be a matter of pre-commit run --all and push the resulting change to the pre-commit-config.yaml).
…ooling (WayScience#17) * run linux tests on dev branch * don't show if headless * install qt deps * try async setting * Update run-tests.yml * try additional qt libs * troubleshoot further with docker * linting * Update run-tests.yml * Update run-tests.yml * Update run-tests.yml * Update uv.lock * fallback to napari[all] and setup qt for ubuntu * move to macos-14 for tests * add python3-pyqt5 installation * attempt to install different qt deps * Update run-tests.yml * attempt another linux dep step * update for linting step * update docs
Member
Author
|
@d33bs I think I fixed this issue! Can you confirm quickly that I didn't mess anything up? |
MikeLippincott
pushed a commit
to MikeLippincott/nViz
that referenced
this pull request
Sep 29, 2025
* update labels parameter to include default * [pre-commit.ci lite] apply automatic fixes * Enable Linux compatibility with dependency changes and improved dev tooling (WayScience#17) * run linux tests on dev branch * don't show if headless * install qt deps * try async setting * Update run-tests.yml * try additional qt libs * troubleshoot further with docker * linting * Update run-tests.yml * Update run-tests.yml * Update run-tests.yml * Update uv.lock * fallback to napari[all] and setup qt for ubuntu * move to macos-14 for tests * add python3-pyqt5 installation * attempt to install different qt deps * Update run-tests.yml * attempt another linux dep step * update for linting step * update docs * [pre-commit.ci lite] apply automatic fixes * fix conflict i hope * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Dave Bunten <dave.bunten@cuanschutz.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have added None as the default for
labels_dirto avoid an error popping up if you do not assign a labels directory in the functions. This solves issue #18.What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.