Repository navigation
fix: render the open-with-AI dropdown as an ARIA menu - #12
Open
EricAndrechek wants to merge 1 commit into
Open
EricAndrechek wants to merge 1 commit into
EricAndrechek wants to merge 1 commit into
Conversation
Replace <details>/<summary> with the WAI-ARIA menu-button pattern: a button (aria-haspopup/expanded/controls) and a role=menu list of role=menuitem links with roving tabindex. Arrow, Home/End, type-ahead, Escape and Tab handling live in a pure, unit-tested helper (src/lib/menu-keys.ts). Adds node:test unit tests and runs them in CI. Closes #11 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GgSsyTuDULnYbCwrjB3E51
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
The dropdown was a
<details>with a plain<ul>inside<main>, so content passes treated the labels as prose (astro-trademarks put a ™ on "Claude").<button>witharia-haspopup="menu",aria-expanded,aria-controls.<ul role="menu" aria-labelledby>with<li role="none">/<a role="menuitem" tabindex="-1">; divider isrole="separator".src/lib/menu-keys.ts. Re-inits onastro:page-load.data-tm-skipadded (roles alone verified sufficient, see below).pnpm test(node:test, 9 tests), now part ofverifyand CI.Verification: ran astro-trademarks
transformHtml(registry Claude, contentRoots main, default + Starlight skips) on the markup: roles present -> no mark; roles removed (andhiddenremoved) -> Claude marked. Keys driven in headless Chromium over CDP against the compiled component script: all pass.Pre-push reviewer agents (pre-push-reviewer, docs-reviewer) were not run: unavailable from the spawning session.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GgSsyTuDULnYbCwrjB3E51