Repository navigation
deps(tests): bump @vitest/coverage-v8 from 4.1.7 to 4.1.8 in /tests/e2e/sdk in the e2e-deps group across 1 directory - #211
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@dependabot rebase (branch predates the #190 root-lockfile consolidation — CI fails with |
c299c58 to
9ee174f
Compare
9ee174f to
ba155cb
Compare
|
@dependabot rebase |
Bumps the e2e-deps group with 1 update in the /tests/e2e/sdk directory: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8). Updates `@vitest/coverage-v8` from 4.1.7 to 4.1.8 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/coverage-v8) --- updated-dependencies: - dependency-name: "@vitest/coverage-v8" dependency-version: 4.1.8 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: e2e-deps ... Signed-off-by: dependabot[bot] <support@github.com>
ba155cb to
85a37da
Compare
## Problem Every Dependabot **npm** PR has been failing CI since the #190 root-lockfile consolidation — e.g. #211 (`@vitest/coverage-v8` in `tests/e2e/sdk`) and #337 (the `docs` group). They fail fast on Lint/Unit/E2E/Coverage and **a rebase never fixes them**. Root cause is the Dependabot config, not the dependencies. The repo is a pnpm workspace with a **single root `pnpm-lock.yaml`**, but `.github/dependabot.yml` pointed its three npm entries at the *member* directories (`directory: /docs`, `/clients/ts`, `/tests/e2e/sdk`). Dependabot only updates a lockfile co-located with the manifest it targets, so it edited the member `package.json` but **left the root lockfile untouched**. CI then runs `pnpm install --frozen-lockfile`, the lockfile's recorded specifier no longer matches `package.json`, and it aborts with `ERR_PNPM_OUTDATED_LOCKFILE`. A rebase only replays the same `package.json`-only change onto fresh `main` — it never regenerates the lockfile, so the mismatch returns every run. (#337, created well after #190, fails identically — confirming it's structural, not a stale branch.) ## Fix Replace the three per-member npm entries with **one entry at the workspace root** (`directory: /`, group `npm-deps`, prefix `deps`). At the root, Dependabot reads `pnpm-workspace.yaml`, walks every member, and updates the single root lockfile inside the PR. As a bonus it now also covers the root `package.json`'s own devDeps (biome, markdownlint, nyc), which the per-member configs never did. **Trade-off:** one combined weekly npm PR with a single `deps:` prefix, instead of three per-area PRs (`docs:` / `deps(sdk):` / `deps(tests):`). This matches the existing grouped `go-deps` / `actions-deps` configs and the team's stated preference for fewer Monday PRs. ## Docs sync - `docs/src/content/docs/development.md` — Dependabot section: five configs → three, plus the root-lockfile rationale. - `SECURITY.md` — supply-chain line: "three npm workspaces" → one root npm config. - `CHANGELOG.md` — `[Unreleased] → Changed` entry. ## Note (out of scope) `pnpm-workspace.yaml` sets `minimumReleaseAge: 10080` (7-day cooldown), which Dependabot doesn't honor. When the new config regenerates lockfiles, a dep released <7 days ago can be held by the cooldown at install time — so a freshly-cut bump may need a few days before it merges cleanly. Pre-existing; the no-auto-merge + admin-review gate covers it. ## Follow-up on the broken PRs Once this merges, the old per-member configs no longer exist, so #211 and #337 should be **closed** (not rebased — rebasing keeps the old member-directory branch and reproduces the failure). The new root config regenerates correct combined PRs on the next Dependabot run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
closed by #340 |
Pull request was closed
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the e2e-deps group with 1 update in the /tests/e2e/sdk directory: @vitest/coverage-v8.
Updates
@vitest/coverage-v8from 4.1.7 to 4.1.8Release notes
Sourced from @vitest/coverage-v8's releases.
Commits
e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...