Skip to content

deps(tests): bump @vitest/coverage-v8 from 4.1.7 to 4.1.8 in /tests/e2e/sdk in the e2e-deps group across 1 directory - #211

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/tests/e2e/sdk/e2e-deps-23042886c7
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/tests/e2e/sdk/e2e-deps-23042886c7

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the e2e-deps group with 1 update in the /tests/e2e/sdk directory: @vitest/coverage-v8.

Updates @vitest/coverage-v8 from 4.1.7 to 4.1.8

Release notes

Sourced from @​vitest/coverage-v8's releases.

v4.1.8

   🐞 Bug Fixes

    View changes on GitHub
Commits
  • e61f2dd chore: release v4.1.8
  • e4067b3 fix(browser): disable client cdp API when allowWrite/allowExec: false [ba...
  • See full diff in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: e2fb54e4-5719-4ef6-b87e-af11484d7277

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the area/sdk TypeScript SDK (clients/ts/) label Jun 2, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by dependabot-automerge workflow (version-update:semver-patch).

@github-actions
github-actions Bot enabled auto-merge (squash) June 2, 2026 23:13
@github-project-automation github-project-automation Bot moved this from Backlog to In progress in WaveHouse Task Board Jun 2, 2026
@EricAndrechek EricAndrechek moved this from In progress to In review in WaveHouse Task Board Jun 3, 2026
@EricAndrechek

Copy link
Copy Markdown
Member

@dependabot rebase

(branch predates the #190 root-lockfile consolidation — CI fails with ERR_PNPM_OUTDATED_LOCKFILE; regenerating against current main should clear it)

@dependabot dependabot Bot changed the title deps(tests): bump @vitest/coverage-v8 from 4.1.7 to 4.1.8 in /tests/e2e/sdk in the e2e-deps group deps(tests): bump @vitest/coverage-v8 from 4.1.7 to 4.1.8 in /tests/e2e/sdk in the e2e-deps group across 1 directory Jun 5, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/tests/e2e/sdk/e2e-deps-23042886c7 branch from c299c58 to 9ee174f Compare June 5, 2026 21:30

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by dependabot-automerge workflow (version-update:semver-patch).

@github-project-automation github-project-automation Bot moved this from In review to In progress in WaveHouse Task Board Jun 5, 2026
@EricAndrechek EricAndrechek mentioned this pull request Jun 5, 2026
30 of 31 tasks
@EricAndrechek EricAndrechek moved this from In progress to In review in WaveHouse Task Board Jun 8, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/tests/e2e/sdk/e2e-deps-23042886c7 branch from 9ee174f to ba155cb Compare June 8, 2026 16:12

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by dependabot-automerge workflow (version-update:semver-patch).

@github-project-automation github-project-automation Bot moved this from In review to In progress in WaveHouse Task Board Jun 8, 2026
@EricAndrechek EricAndrechek moved this from In progress to In review in WaveHouse Task Board Jun 9, 2026
@EricAndrechek

Copy link
Copy Markdown
Member

@dependabot rebase

Bumps the e2e-deps group with 1 update in the /tests/e2e/sdk directory: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8).


Updates `@vitest/coverage-v8` from 4.1.7 to 4.1.8
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/coverage-v8)

---
updated-dependencies:
- dependency-name: "@vitest/coverage-v8"
  dependency-version: 4.1.8
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: e2e-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/tests/e2e/sdk/e2e-deps-23042886c7 branch from ba155cb to 85a37da Compare June 10, 2026 23:34
@dependabot
dependabot Bot requested review from a team and EricAndrechek June 10, 2026 23:34
EricAndrechek added a commit that referenced this pull request Jun 11, 2026
## Problem

Every Dependabot **npm** PR has been failing CI since the #190
root-lockfile consolidation — e.g. #211 (`@vitest/coverage-v8` in
`tests/e2e/sdk`) and #337 (the `docs` group). They fail fast on
Lint/Unit/E2E/Coverage and **a rebase never fixes them**.

Root cause is the Dependabot config, not the dependencies. The repo is a
pnpm workspace with a **single root `pnpm-lock.yaml`**, but
`.github/dependabot.yml` pointed its three npm entries at the *member*
directories (`directory: /docs`, `/clients/ts`, `/tests/e2e/sdk`).
Dependabot only updates a lockfile co-located with the manifest it
targets, so it edited the member `package.json` but **left the root
lockfile untouched**. CI then runs `pnpm install --frozen-lockfile`, the
lockfile's recorded specifier no longer matches `package.json`, and it
aborts with `ERR_PNPM_OUTDATED_LOCKFILE`. A rebase only replays the same
`package.json`-only change onto fresh `main` — it never regenerates the
lockfile, so the mismatch returns every run. (#337, created well after
#190, fails identically — confirming it's structural, not a stale
branch.)

## Fix

Replace the three per-member npm entries with **one entry at the
workspace root** (`directory: /`, group `npm-deps`, prefix `deps`). At
the root, Dependabot reads `pnpm-workspace.yaml`, walks every member,
and updates the single root lockfile inside the PR. As a bonus it now
also covers the root `package.json`'s own devDeps (biome, markdownlint,
nyc), which the per-member configs never did.

**Trade-off:** one combined weekly npm PR with a single `deps:` prefix,
instead of three per-area PRs (`docs:` / `deps(sdk):` / `deps(tests):`).
This matches the existing grouped `go-deps` / `actions-deps` configs and
the team's stated preference for fewer Monday PRs.

## Docs sync

- `docs/src/content/docs/development.md` — Dependabot section: five
configs → three, plus the root-lockfile rationale.
- `SECURITY.md` — supply-chain line: "three npm workspaces" → one root
npm config.
- `CHANGELOG.md` — `[Unreleased] → Changed` entry.

## Note (out of scope)

`pnpm-workspace.yaml` sets `minimumReleaseAge: 10080` (7-day cooldown),
which Dependabot doesn't honor. When the new config regenerates
lockfiles, a dep released <7 days ago can be held by the cooldown at
install time — so a freshly-cut bump may need a few days before it
merges cleanly. Pre-existing; the no-auto-merge + admin-review gate
covers it.

## Follow-up on the broken PRs

Once this merges, the old per-member configs no longer exist, so #211
and #337 should be **closed** (not rebased — rebasing keeps the old
member-directory branch and reproduces the failure). The new root config
regenerates correct combined PRs on the next Dependabot run.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@EricAndrechek

Copy link
Copy Markdown
Member

closed by #340

auto-merge was automatically disabled June 11, 2026 15:23

Pull request was closed

@github-project-automation github-project-automation Bot moved this from In review to Done in WaveHouse Task Board Jun 11, 2026
@dependabot @github

dependabot Bot commented on behalf of github Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/tests/e2e/sdk/e2e-deps-23042886c7 branch June 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sdk TypeScript SDK (clients/ts/) dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant