Area: mq — external NATS, deferred follow-ups
#624's own change description called out several items as deliberately left for later. Each is described here on its own so it can be picked up independently; none of them block #624, and none were independently re-measured beyond what is noted.
1. Membership read cost. claimLoop.readMembers (internal/ingest/claims.go:367) reads every membership slot's lease every tick (coord.RetryPeriod, 2s by default) — one Held lookup per slot, up to membershipReaders (16, claims.go:92) in flight at once, capped at min(units, 64) slots. At the shipped default topology this is a bounded, modest read volume, but it grows with the configured slot count, and a failed read skips acting on the whole tick (tick's doc comment: "acting on a partial view of the members would move units for nothing"). Whether this read pattern is cheap enough at larger slot counts, and whether a failed read skipping the entire tick causes visible reassignment lag under a flaky coordinator, has not been measured.
2. Batching Unowned. ExternalNATS.Unowned (internal/mq/external.go:824) loops over every configured and extra unit and issues one e.js.Consumer(ctx, ...) API round trip per unit, sequentially, to read each durable's ConsumerInfo. This is called periodically (per the wavehouse_ingest_shards_unowned gauge, read every 15s by the lowest-ranked member only, per deployment.md). At larger V (shards per partition) this is N×V sequential round trips per read; batching them (concurrently, or via a JetStream API that can answer for several consumers at once) was left as a follow-up rather than done in #624.
3. A lone process's crash-restart wait. The original design note for this item said a lone process, after crashing and restarting, "gets the dead run's rows back after ack_wait, not at once." Reading the current code (internal/ingest/claims.go's take, and internal/mq/external.go's ResetOrphaned/recentlyActive) suggests this may be more favorable than that: take marks every target unit "orphaned" immediately when a process finds itself alone (alone := l.prev == nil && len(live) == 1 && live[0] == l.slot), then retries ResetOrphaned every tick (2s) until either it succeeds or orphanWait (30s, claims.go:96) elapses, at which point it proceeds to bind anyway. Since ResetOrphaned typically succeeds once the crashed run's old pin has lapsed and it is no longer "recently active" — both keyed to PinnedTTL/minPinnedTTL, on the order of 10s — the wait in practice looks closer to ~10–30s than the full ack_wait default of 60s. This has not been measured end-to-end, so whether the original concern still applies (or in what scenario it still would) is unconfirmed.
4. Allocations on the hot ownership/delivery path. Noted as worth trimming in the change description; no specific allocation was pointed at, and none was independently profiled here.
5. The --coord-bucket docs pointer. The change description flagged that wavehouse mq permissions/mq manifests's --coord-bucket flag needed a docs pointer. Current docs/src/content/docs/deployment.md:357 and configuration.mdx:90 both already document --coord-bucket and its relationship to coord.nats.bucket, so this item appears to already be addressed — worth confirming rather than re-doing.
6. Per-tenant budgets under the nats backend (deferred when #624 was designed). The decision recorded then: "Partition/shard key is tenant+table (consistent hash); a flooding tenant touches every partition; per-tenant budgets are a later follow-up. Accepted." Today, mq.max_bytes_gb (the settings-directory per-tenant queue budget) is explicitly not applied under mq.backend: nats — a boot-time warning says so (internal/config/mq_nats.go's natsWarnings: "mq.max_bytes_gb (settings directory) is not applied with mq.backend=nats: a tenant's queue is bounded by its partition stream's limits, which are the operator's"). A tenant publishing heavily therefore consumes shared partition capacity with no per-tenant cap, by design, until this is picked up.
Found in review of #624.
Related: #624, #613.
Area: mq — external NATS, deferred follow-ups
#624's own change description called out several items as deliberately left for later. Each is described here on its own so it can be picked up independently; none of them block #624, and none were independently re-measured beyond what is noted.
1. Membership read cost.
claimLoop.readMembers(internal/ingest/claims.go:367) reads every membership slot's lease every tick (coord.RetryPeriod, 2s by default) — oneHeldlookup per slot, up tomembershipReaders(16,claims.go:92) in flight at once, capped atmin(units, 64)slots. At the shipped default topology this is a bounded, modest read volume, but it grows with the configured slot count, and a failed read skips acting on the whole tick (tick's doc comment: "acting on a partial view of the members would move units for nothing"). Whether this read pattern is cheap enough at larger slot counts, and whether a failed read skipping the entire tick causes visible reassignment lag under a flaky coordinator, has not been measured.2. Batching
Unowned.ExternalNATS.Unowned(internal/mq/external.go:824) loops over every configured and extra unit and issues onee.js.Consumer(ctx, ...)API round trip per unit, sequentially, to read each durable'sConsumerInfo. This is called periodically (per thewavehouse_ingest_shards_unownedgauge, read every 15s by the lowest-ranked member only, perdeployment.md). At larger V (shards per partition) this is N×V sequential round trips per read; batching them (concurrently, or via a JetStream API that can answer for several consumers at once) was left as a follow-up rather than done in #624.3. A lone process's crash-restart wait. The original design note for this item said a lone process, after crashing and restarting, "gets the dead run's rows back after
ack_wait, not at once." Reading the current code (internal/ingest/claims.go'stake, andinternal/mq/external.go'sResetOrphaned/recentlyActive) suggests this may be more favorable than that:takemarks every target unit "orphaned" immediately when a process finds itself alone (alone := l.prev == nil && len(live) == 1 && live[0] == l.slot), then retriesResetOrphanedevery tick (2s) until either it succeeds ororphanWait(30s,claims.go:96) elapses, at which point it proceeds to bind anyway. SinceResetOrphanedtypically succeeds once the crashed run's old pin has lapsed and it is no longer "recently active" — both keyed toPinnedTTL/minPinnedTTL, on the order of 10s — the wait in practice looks closer to ~10–30s than the fullack_waitdefault of 60s. This has not been measured end-to-end, so whether the original concern still applies (or in what scenario it still would) is unconfirmed.4. Allocations on the hot ownership/delivery path. Noted as worth trimming in the change description; no specific allocation was pointed at, and none was independently profiled here.
5. The
--coord-bucketdocs pointer. The change description flagged thatwavehouse mq permissions/mq manifests's--coord-bucketflag needed a docs pointer. Currentdocs/src/content/docs/deployment.md:357andconfiguration.mdx:90both already document--coord-bucketand its relationship tocoord.nats.bucket, so this item appears to already be addressed — worth confirming rather than re-doing.6. Per-tenant budgets under the
natsbackend (deferred when #624 was designed). The decision recorded then: "Partition/shard key is tenant+table (consistent hash); a flooding tenant touches every partition; per-tenant budgets are a later follow-up. Accepted." Today,mq.max_bytes_gb(the settings-directory per-tenant queue budget) is explicitly not applied undermq.backend: nats— a boot-time warning says so (internal/config/mq_nats.go'snatsWarnings: "mq.max_bytes_gb (settings directory) is not applied with mq.backend=nats: a tenant's queue is bounded by its partition stream's limits, which are the operator's"). A tenant publishing heavily therefore consumes shared partition capacity with no per-tenant cap, by design, until this is picked up.Found in review of #624.
Related: #624, #613.