Repository navigation
bug(api): schema Refresh ignores rows.Err() — a mid-stream error installs a truncated schema #391
Description
Activity
🔗 Related PRs
#125 - fix(boot): non-fatal schema discovery, /health 503 with diagnostic [merged]
#182 - refactor: full api --> ingest --> clickhouse --> dlq refactor [closed]
🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your
.coderabbit.yaml:issue_enrichment: auto_enrich: enabled: false
💬 Have feedback or questions? Drop into our discord!
Fixed in #402.
Refreshnow checksrows.Err()after iteratingsystem.columnsand returns the error before the registry is swapped (internal/discovery/discovery.go). A mid-stream driver error therefore keeps the previous schema instead of publishing a truncated one. Thesystem.tablesscan added later in #550 has the same check, andTestRefresh_RowsIterationError_Failsininternal/discovery/discovery_test.gocovers the case with a simulated network drop.
Summary
SchemaRegistry.Refreshiteratessystem.columnsrows but never checksrows.Err(), so a transient error partway through the result set swaps in a partial schema as authoritative and logs it as a success.Detail
internal/discovery/discovery.go:84-108: thefor rows.Next()loop ends on error as well as EOF;driver.Rows.Err()(present in clickhouse-go v2.46) is never consulted. A network hiccup / cancellation mid-result yields a truncatedtablesmap that is installed under lock and logged "schema registry refreshed".Because auto-refresh runs every 60s, a single transient stream error makes tables after the break disappear (ingest/query → 404), truncates the last table's column list (valid rows rejected as "unknown/missing column";
select_allsilently drops columns) — until the next successful refresh. Fail-silent where the rest of boot is fail-loud.Fix direction
Check
rows.Err()after the loop and return the error without swappingsr.tables.Found in a repo-wide audit; verified by code trace.