Repository navigation
chore(coverage): restore SDK statements coverage threshold to ≥50 #176
Description
Activity
🔗 Related PRs
#123 - fix(api): drop CORS credentials + skip same-origin decoration [merged]
📝 Issue Planner
Check the box below or use the
@coderabbitai plancommand to generate an implementation plan and prompts that you can use with your favorite coding assistant.- Create Plan
🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your
.coderabbit.yaml:issue_enrichment: auto_enrich: enabled: false
💬 Have feedback or questions? Drop into our discord!
_createStream transport-selection test coverage
Flagged in PR #174 (comment: #174 (comment)) — the
_createStreamtransport-selection test suite was removed because the async SSE auth path broke the sync-vs-async detection hack used to distinguish SSE from WS.Specific cases that need to be covered once the testing approach is updated:
- Auto mode, no auth → SSE transport is selected (
EventSourceconstructor is called) - Auto mode, auth present → WS transport is selected (
WebSocketconstructor is called) - Forced SSE with auth → SSE transport is selected even when auth is set; auth token is injected as
tokenquery parameter in the SSE URL - Disconnect lifecycle →
disconnect()closes the connection, decrements the active connection counter (clamped to 0), and emits aclosedstatus
Requested by @EricAndrechek.
- Auto mode, no auth → SSE transport is selected (
- added a commit that references this issue
on Jun 2, 2026
Metadata
Metadata
Assignees
Type
Projects
- Status
Summary
The SDK statements coverage threshold in
.testcoverage.ymlwas temporarily lowered from 50 → 40 in #174 ("refactor(table names): handle unsafe table names") to keep the PR scope manageable while new SDK endpoint/auth behavior was being shipped.Goal
Restore the
sdkstatements threshold to 50 or higher once targeted SDK tests covering the new query-parameter endpoints and SSE auth changes are added.Context
suites.sdkin.testcoverage.ymlclients/ts/src/table.ts— ingest/schema endpoints changed to?table=query paramsclients/ts/src/query-builder.ts— query endpoint changed to/v1/query?table=clients/ts/src/stream/sse.ts—SSEOptionsgained optionalauthcallback; reconnect/error handling expandedclients/ts/src/client.ts—_createStreamnow passesauthtoSSETransportRequested by
@EricAndrechek