-
Notifications
You must be signed in to change notification settings - Fork 63
docs: update plugin introduction #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, all the patches are minor and do not seem to cause any potential problems. Most of them involve fixing typos or updating the formatting of the WasmEdge plugin documentation. Some patches include adding an architecture diagram or updating the flowchart to better fit the document's flow. The most important finding is that the updates emphasize the key benefits of using the WasmEdge plugin system, such as versatility, customization, performance, and ease of use. The patches also highlight the importance of using plugins to improve scalability and simplify development on edge devices. DetailsCommit e831c822080e7527fc3fcf923ef1ff9c8bc37a21Key Changes:
Potential Problems:
Commit 2b6ac2c0a3a00401f3f5d908870ce4bee545caffKey changes:
Potential problems:
Commit 65fc73bfaf90c5bffb5d4e9b7930079acb8e7071The patch updates the formatting of the introduction section of the plugin documentation. The changes involve replacing quotes with asterisks to highlight certain parts of the text. There are no potential problems identified in the patch and the changes seem minor. The only thing to note is that this patch is one of a series of nine patches, so there may be additional changes made in other patches that need to be reviewed as well. Commit 2eeb7d58d500c030e5e34b71ff1681a5fac7b9c0Key changes:
Potential problems:
Commit 6008f56d8426fcefaa8ee2da7da08131debdc185Key changes:
Potential problems:
Commit 67f2f5324ba19cd19b3788606bb875d2376ffbe4Key Changes:
Potential Problems:
Commit f3a2b87d921ea81509eb26fc3ab8a0f010b1c6e4The patch only contains the deletion of one line of text that was a blank line. The significant changes were made in another patch. There are no potential problems identified in this specific patch. Commit a34b7facaf568f1cc950b34777d37f753259a56fThe key change in this patch is the removal of white space. Specifically, there was an additional blank line added before the introduction section. The patch removes this blank line. There do not appear to be any major potential problems with this patch. However, it is a very small and simple change, and it may not be necessary to submit such a minor pull request. Commit 54988d0ca52cedd498aa6cfa0ad9dcbbc26a62d2Summary: The patch updates the format of the introductory section of the WasmEdge plugin documentation. Instead of bulleted list items, headings are used to emphasize key points. Key Changes:
Potential Problems: Based on the patch, no potential problems can be identified. The changes seem to be formatting-related and do not affect the content of the documentation. |
Signed-off-by: Mahfuza Humayra Mohona mhmohona@gmail.com
Signed-off-by: Mahfuza Humayra Mohona <mhmohona@gmail.com>
Signed-off-by: mhmohona <mhmohona@gmail.com>
@mhmohona Could you please fix the DCO test first? |
Signed-off-by: mhmohona <mhmohona@gmail.com>
Signed-off-by: mahfuza <mhmohona@gmail.com>
@q82419 Could you please take a look? |
@mhmohona Could you please fix the DCO check? |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhmohona Can we please make the above changes?
Signed-off-by: mahfuza <mhmohona@gmail.com>
Hi @mhmohona Please fix the DCO test and then we can merge this PR. Thanks. |
Reopened another PR to pass DOC test - #105 |
Explanation
Updated plugin PR adding more info about
Related issue
What type of PR is this
/kind documentation
Proposed Changes