Skip to content

bug on attachement when updating to cucumberjs 10+ #298

@lerhum

Description

@lerhum

Environment (please complete the following information):

multiple-cucumber-html-reporter: 3.4.0
Node.js version: v18.17.1
NPM version: 9.6.7
Platform name and version: mac os
Cucumber version: 10.0.1

Describe the bug
In the JSON formatter output of multiple-cucumber-html-reporter, all attachments, including those initially attached as plain text strings, are now Base64 encoded. This uniform encoding approach leads to ambiguity for consumers of the report, as they cannot distinguish whether an attachment was originally a plain text string or a different file format.

To Reproduce
Steps to reproduce the behavior:

just generate a report based on cucumber 10.0.1 with some attachement (json/ text / image)

Expected behavior
The expected behavior was that string attachments would remain as plain text in the JSON formatter output, while other types of attachments would be Base64 encoded. This distinction would enable consumers to easily identify the nature of the attachments without additional processing.

Additional context
To resolve this issue, a decoding mechanism such as atob(embedding.data); should be implemented to correctly decode Base64 attachments before passing them to the report. This would ensure that plain text attachments maintain their original format in the JSON output.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions