limits not part of std with GCC 14.1.0

[DetlevCM]

I'm trying to compile Workbench v1.5.0 as a dependency for a colleague (with issues thus far) and came across an error that numeric_limits is not part of std. - This is using GCC 14.1.0 on an openSUSE distribution.

-> The solution was to add #include <limits> to the relevant header files.
These are:

• workbench-1.5.0/src/Charting/ChartTwoCartesianCustomSubdivisions.h
• workbench-1.5.0/src/Brain/SelectionItemChartTwoLineLayerVerticalNearest.h
• workbench-1.5.0/src/Brain/ChartTwoOverlay.h
• workbench-1.5.0/src/Charting/EventChartTwoCartesianOrientedAxesYoking.h

(I'm compiling off a release version without a git history... - Also, I have no way to test the result as I am not the end user, plus I'm running into other compile issues, but that is a different topic.)

[johnvelab]

Sometimes when we move source code to a different operating system (macos to linux) we run into these types of issues (have to add #include directives). However, I do not see any usage of “numeric_limits” in the header files and there are includes for <limits> in the CXX files. Do you have CMAKE_CXX_STANDARD defined to 11, 14 or 17 when configuring the Workbench source code with CMAKE (-DCMAKE_CXX_STANDARD=17)? I saw some reports that if the C++ standard is not defined, “is not part of std” errors may occur. John Harwell From: Detlev C M ***@***.***> Date: Sunday, May 26, 2024 at 5:26 AM To: Washington-University/workbench ***@***.***> Cc: Subscribed ***@***.***> Subject: [Washington-University/workbench] limits not part of std with GCC 14.1.0 (Issue #76) * External Email - Caution * I'm trying to compile Workbench v1.5.0 as a dependency for a colleague (with issues thus far) and came across an error that numeric_limits is not part of std. - This is using GCC 14.1.0 on an openSUSE distribution. -> The solution was to add #include <limits> to the relevant header files. These are: · workbench-1.5.0/src/Charting/ChartTwoCartesianCustomSubdivisions.h · workbench-1.5.0/src/Brain/SelectionItemChartTwoLineLayerVerticalNearest.h · workbench-1.5.0/src/Brain/ChartTwoOverlay.h · workbench-1.5.0/src/Charting/EventChartTwoCartesianOrientedAxesYoking.h (I'm compiling off a release version without a git history... - Also, I have no way to test the result as I am not the end user, plus I'm running into other compile issues, but that is a different topic.) — Reply to this email directly, view it on GitHub<#76>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALSGXACU4QDN3XPDEO4HX3ZEG2FNAVCNFSM6AAAAABIJVWPSGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTONRSG44DMNI>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

…

________________________________ The materials in this message are private and may contain Protected Healthcare Information or other information of a sensitive nature. If you are not the intended recipient, be advised that any unauthorized use, disclosure, copying or the taking of any action in reliance on the contents of this information is strictly prohibited. If you have received this email in error, please immediately notify the sender via telephone or return mail.