feat: adds ssh url in action's check#1
Merged
prajjwaldimri merged 17 commits intomasterfrom Oct 18, 2023
Merged
Conversation
prajjwaldimri
commented
Oct 17, 2023
prajjwaldimri
commented
- Also fixes tests
abhijit-hota
requested changes
Oct 18, 2023
Member
abhijit-hota
left a comment
abhijit-hota
left a comment
There was a problem hiding this comment.
Added some minor change requests from what I can see. A few more things that can be addressed:
- Can move the
os/distro->package manager commandlogic to acomposeInstallationCommandfunction. - Should we add support for the following? I think at least
redhatshould be added.Distro Package manager redhatyumopenSUSEzyppgentooemerge - Can move the
sleepandcontinueFileExistsfunctions tohelpers.js.
abhijit-hota
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.