-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
33th Bug Crusade #1708
Merged
Merged
33th Bug Crusade #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lor'themar is no longer both hunter and warrior.
Fixed an issue where the war between Illidan and the Scourge in the 605th startdate ended when Arthas became the Lich King.
Fixed parser.cpp:697 error from error.log.
Fixed an issue where the Burningblade dynasty CoA (the first ruler of the Burning Blade clan) was blank. (GDC)
Fixed an issue where you could keep political faction members as alliances after being overthrown in a revolt.
Fixed an issue where you could release faction tributaries of the Horde and Alliance leaders.
Aegwynn and Rastakhan have Immortal traits now thus can't die of old age in a few days like before.
zumbak04
added
❗ priority critical
Issue or addition is of upmost importance
🔧 bug fix 🔨
Fixes a previous problem or bug
labels
Jul 17, 2020
KoiKarp
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is as it should be, from what i've seen.
Added mod traits in is_inaccessible_trigger.
Myrran
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Lor’themar has only one class at the start - hunter level 7;
- “Release Tributary” decision is not shown on characters that are faction tributaries;
- War between Illidan and the Scourge in the 605th startdate doesn’t end when Arthas becomes the Lich King;
- The Burningblade dynasty CoA is not blank (is in place);
- Aegwynn has immortal trait;
- Rastakhan has immortal trait;
- parser.cpp:697 error doesn’t appear in the error.log;
- Checked is_inaccessible_trigger – seems to work fine with the new traits;
- Political faction alliances are broken after being overthrown in a revolt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
❗ priority critical
Issue or addition is of upmost importance
🔧 bug fix 🔨
Fixes a previous problem or bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
How to test: play an Ironforge vassal, start Overthrown faction, send your demands via the decisions, switch to the Ironforge's King, accept the demands.
Developer changelog:
parser.cpp:697
error from error.log.Script changelog (ignore if you can't read CK2 script):
is_inaccessible_trigger
.How to test:
event WCSDW.1
to spawn the Burning Blade clan.First, you need to find out how to turn on Log Files.
Then open the game, start any character, close the game, open
error.log
and try to find the errors I mentioned. If you don't find any, well, it means they're fixed... yay!Also, it would be cool if you can read the CK2 script and take a look at Files changed above.
To find more info about the issue... including screenshots, click on
#<Issue ID>
... if there's any.Fixed #1294, fixed #897.