Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33th Bug Crusade #1708

Merged
merged 14 commits into from
Jul 18, 2020
Merged

33th Bug Crusade #1708

merged 14 commits into from
Jul 18, 2020

Conversation

zumbak04
Copy link
Member

@zumbak04 zumbak04 commented Jul 17, 2020

Changelog:

  • Lor'themar is no longer both hunter and warrior.
  • Fixed an issue where you could keep political faction members as alliances after being overthrown in a revolt.
    How to test: play an Ironforge vassal, start Overthrown faction, send your demands via the decisions, switch to the Ironforge's King, accept the demands.
  • Fixed an issue where you could release faction tributaries of the Horde and Alliance leaders.

Developer changelog:

  • Fixed an issue where the war between Illidan and the Scourge in the 605th startdate ended when Arthas became the Lich King.
  • Fixed parser.cpp:697 error from error.log.
  • Fixed an issue where the Burningblade dynasty CoA (the first ruler of the Burning Blade clan) was blank.
  • Aegwynn and Rastakhan have Immortal traits now thus can't die of old age in a few days like before.

Script changelog (ignore if you can't read CK2 script):

  • Added mod traits in is_inaccessible_trigger.

How to test:

event WCSDW.1 to spawn the Burning Blade clan.

First, you need to find out how to turn on Log Files.
Then open the game, start any character, close the game, open error.log and try to find the errors I mentioned. If you don't find any, well, it means they're fixed... yay!

Also, it would be cool if you can read the CK2 script and take a look at Files changed above.

To find more info about the issue... including screenshots, click on #<Issue ID>... if there's any.

Fixed #1294, fixed #897.

Lor'themar is no longer both hunter and warrior.
Fixed an issue where the war between Illidan and the Scourge in the 605th startdate ended when Arthas became the Lich King.
Fixed parser.cpp:697 error from error.log.
Fixed an issue where the Burningblade dynasty CoA (the first ruler of the Burning Blade clan) was blank.
(GDC)
Fixed an issue where you could keep political faction members as alliances after being overthrown in a revolt.
Fixed an issue where you could release faction tributaries of the Horde and Alliance leaders.
Aegwynn and Rastakhan have Immortal traits now thus can't die of old age in a few days like before.
@zumbak04 zumbak04 self-assigned this Jul 17, 2020
@zumbak04 zumbak04 added ❗ priority critical Issue or addition is of upmost importance 🔧 bug fix 🔨 Fixes a previous problem or bug labels Jul 17, 2020
@zumbak04 zumbak04 added this to the Patch 1.8.0 milestone Jul 17, 2020
@zumbak04 zumbak04 marked this pull request as ready for review July 17, 2020 12:37
@zumbak04 zumbak04 requested a review from a team as a code owner July 17, 2020 12:37
@zumbak04 zumbak04 requested a review from a team July 17, 2020 12:37
Copy link

@KoiKarp KoiKarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is as it should be, from what i've seen.

@zumbak04 zumbak04 requested a review from a team July 17, 2020 13:05
Added mod traits in is_inaccessible_trigger.
Copy link
Contributor

@Myrran Myrran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lor’themar has only one class at the start - hunter level 7;
  • “Release Tributary” decision is not shown on characters that are faction tributaries;
  • War between Illidan and the Scourge in the 605th startdate doesn’t end when Arthas becomes the Lich King;
  • The Burningblade dynasty CoA is not blank (is in place);
  • Aegwynn has immortal trait;
  • Rastakhan has immortal trait;
  • parser.cpp:697 error doesn’t appear in the error.log;
  • Checked is_inaccessible_trigger – seems to work fine with the new traits;
  • Political faction alliances are broken after being overthrown in a revolt.
Note: Break alliance message fires twice for each alliance broken.

Double message

@zumbak04
Copy link
Member Author

Note: Break alliance message fires twice for each alliance broken.

Paradox bug.

Click to expand

image

Purged if since these conditions are checked in trigger.
(GDC)
@zumbak04 zumbak04 merged commit 6e39d73 into master Jul 18, 2020
@zumbak04 zumbak04 deleted the bug-crusade-33 branch July 18, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ priority critical Issue or addition is of upmost importance 🔧 bug fix 🔨 Fixes a previous problem or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Characters don't break fraction alliance Faction leader can release tributaries-faction members
3 participants