Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adressed #1104 holding types #1588

Merged
merged 4 commits into from
May 23, 2020
Merged

Adressed #1104 holding types #1588

merged 4 commits into from
May 23, 2020

Conversation

zumbak04
Copy link
Member

@zumbak04 zumbak04 commented May 22, 2020 •
edited
Loading

Changelog:

  • Fixed issues around the world where rulers had holdings of the wrong type in their possession.

How to test:

Start any bookmark, pick a few provinces to make sure rulers don't have holdings of the wrong type. Provinces that had issues mentioned here: #1104.

@zumbak04
Adressed #1104 holding types
eb86e59 
Fixed issues around the world where rulers had holdings of wrong type in their possession.
@zumbak04 zumbak04 requested a review from a team as a code owner May 22, 2020 10:48
@zumbak04
Final tweaks
feabbb2 
Made b_ethel_rethor a capital.
Added a temple in c_arkkoran.
@zumbak04 zumbak04 added 🔧 bug fix 🔨 Fixes a previous problem or bug ⚖️ balance ⚖️ Adjustment made to branch to better balance a pre-existing feature ❗ priority critical Issue or addition is of upmost importance labels May 22, 2020
@zumbak04 zumbak04 requested a review from a team May 22, 2020 11:32
@zumbak04 zumbak04 added this to the Patch 1.7.1 milestone May 22, 2020
Alvieck
Alvieck approved these changes May 22, 2020
View reviewed changes
Copy link

@Alvieck Alvieck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zumbak04 zumbak04 requested a review from a team May 22, 2020 11:45
Myrran
Myrran suggested changes May 23, 2020
View reviewed changes
Copy link
Contributor

@Myrran Myrran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding types.xlsx

Here is a list of provinces where rulers have holdings of the wrong type.
“+” means that a holding is of the wrong type.

@zumbak04 zumbak04 self-assigned this May 23, 2020
@zumbak04
More holding issues
ab774a2 
Fixed more holding type issues.
@zumbak04 zumbak04 requested a review from Myrran May 23, 2020 12:20
@zumbak04
Copy link
Member Author

zumbak04 commented May 23, 2020 •
edited
Loading

Here is a list of provinces where rulers have holdings of the wrong type.
“+” means that a holding is of the wrong type.

@KYRAGA very good stuff! Addressed everything in ab774a2 except Fikinnun (wrong culture province) because trolls live there.

Myrran
Myrran approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@Myrran Myrran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good.

@zumbak04 zumbak04 merged commit 137e782 into master May 23, 2020
@zumbak04 zumbak04 deleted the holding-type-issues branch May 23, 2020 13:42
@zumbak04 zumbak04 modified the milestones: Patch 1.7.1, Patch 1.8.0 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myrran Myrran Myrran approved these changes

@Alvieck Alvieck Alvieck approved these changes

Assignees

@zumbak04 zumbak04

Labels
⚖️ balance ⚖️ Adjustment made to branch to better balance a pre-existing feature ❗ priority critical Issue or addition is of upmost importance 🔧 bug fix 🔨 Fixes a previous problem or bug
Projects
None yet
Milestone
Patch 1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zumbak04 @Myrran @Alvieck