Skip to content

Commit

Permalink
Evil Successions Issues
Browse files Browse the repository at this point in the history 
Undead Horde, Demonic Legion and Black Pact governments should never appear with Non-Dark Pact succession type.
Death God, Legion and Shath'yar character should always appear with Undead Horde/Demonic Legion/Black Pact governments.
  • Loading branch information
@zumbak04
zumbak04 committed Oct 30, 2019
1 parent 86513f6 commit 777c3aa
Show file tree
Hide file tree
Showing 7 changed files with 56 additions and 223 deletions.
206 changes: 3 additions & 203 deletions common/laws/succession_laws.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ succession_laws = {

potential = {
# Warcraft
NOT = { has_law = succ_evil_elective }
holder_scope = { evil_government_trigger = no }

# Warcraft
# NAND = {
Expand Down Expand Up @@ -672,7 +672,7 @@ succession_laws = {
dynasty_opinion = -5
potential = {
# Warcraft
NOT = { has_law = succ_evil_elective }
holder_scope = { evil_government_trigger = no }

# Warcraft
# NAND = {
Expand Down Expand Up @@ -991,208 +991,8 @@ succession_laws = {
always = no
}
}
# succ_hre_elective = {
# oldest_child_opinion = -15
# child_opinion = -5
# dynasty_opinion = -5
# vassal_opinion = 15
# vassal_limit = 20
# potential = {
# # Warcraft
# holder_scope = { evil_government_trigger = no }

# NAND = {
# has_law = succ_byzantine_elective
# OR = {
# title = e_byzantium
# title = e_roman_empire
# }
# }
# OR = {
# title = e_hre #Title-bound.
# ROOT = {
# has_title_flag = alternate_hre
# }
# }
# holder_scope = {
# OR = {
# independent = yes
# NOT = {
# any_liege = {
# holy_order = yes
# }
# }
# }
# OR = {
# NOR = {
# religion_group = muslim
# religion_group = indian_group
# }
# has_law = succession_voting_power_1
# has_law = succ_feudal_elective # Keep it even if you revoke Full Council Authority
# has_law = succ_hre_elective
# ROOT = {
# has_title_flag = alternate_hre
# }
# }
# is_merchant_republic = no
# is_patrician = no

# OR = {
# # Warcraft
# is_reformed_religion_trigger = yes
# # NOT = { religion_group = pagan_group }
# # religion = hellenic_pagan
# is_nomadic = no
# OR = {
# culture_group = byzantine
# culture = roman
# religion = orthodox
# religion = hellenic_pagan
# religion = hellenic_pagan_reformed
# }
# OR = {
# independent = yes
# NOT = {
# any_demesne_title = {
# is_vice_royalty = yes
# }
# }
# }
#OR = {
# is_landless_type_title = no
# is_tribal_type_title = yes
# temporary = yes
#}
#is_primary_type_title = no

# has_law = succession_voting_power_1
# has_law = succ_feudal_elective # Keep it even if you revoke Full Council Authority
# has_law = succ_hre_elective
# ROOT = {
# has_title_flag = alternate_hre
# }
# }
# OR = {
# independent = yes
# NOT = {
# any_demesne_title = {
# is_vice_royalty = yes
# }
# }
# }
# }
# OR = {
# # Warcraft
# is_landless_type_title_trigger = no

# is_tribal_type_title = yes
# temporary = yes
# }

# # Warcraft
# is_primary_type_title_trigger = no

# NOT = { tier = baron }
# holder_scope = {
# OR = {
# is_feudal = yes
# has_law = succession_voting_power_1
# has_law = succ_feudal_elective # Keep it even if you revoke Full Council Authority
# has_law = succ_hre_elective
# ROOT = {
# has_title_flag = alternate_hre
# }
# }
# }
# NOT = { holder_scope = { government = confucian_bureaucracy } }
# NOT = { holder_scope = { government = chinese_imperial_government } }
# }
# allow = {
# custom_tooltip = {
# text = not_forced_tt
# hidden_tooltip = {
# holder_scope = { NOT = { has_character_flag = liege_forced_succ_law } }
# }
# }
# }
# effect = {
# succession = {
# base_type = feudal_elective
# voting_rules = hre_feudal_elective
# }
# }
# revoke_allowed = {
# always = no
# }
# }

# succ_byzantine_elective = {
# oldest_child_opinion = -5
# child_opinion = -5
# dynasty_opinion = -5
# feudal_opinion = -5
# potential = {
# # Warcraft
# holder_scope = { evil_government_trigger = no }

# holder_scope = {
# OR = {
# has_landed_title = e_byzantium
# has_landed_title = e_roman_empire
# }
# NOT = { religion_group = muslim }
# is_merchant_republic = no
# is_patrician = no
# OR = {
# culture_group = byzantine
# culture = roman
# religion = orthodox
# religion = hellenic_pagan
# religion = hellenic_pagan_reformed
# }
# OR = {
# independent = yes
# NOT = {
# any_demesne_title = {
# is_vice_royalty = yes
# }
# }
# }
# }
# OR = {
# # Warcraft
# is_landless_type_title_trigger = no

# is_tribal_type_title = yes
# temporary = yes
# }

# # Warcraft
# is_primary_type_title_trigger = no

# NOT = { holder_scope = { government = confucian_bureaucracy } }
# NOT = { holder_scope = { government = chinese_imperial_government } }

# }
# allow = {
# custom_tooltip = {
# text = not_forced_tt
# hidden_tooltip = {
# holder_scope = { NOT = { has_character_flag = liege_forced_succ_law } }
# }
# }
# }
# effect = {
# succession = {
# base_type = feudal_elective
# voting_rules = byzantine_elective
# }
# }
# revoke_allowed = {
# always = no
# }
# }
# Warcraft

succ_tanistry = {
oldest_child_opinion = -20
Expand Down
5 changes: 3 additions & 2 deletions common/on_actions/00_on_actions.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3111,6 +3111,7 @@ on_create_title = {
# ROOT is the character, FROM is the title, FROMFROM is the old holder
on_new_holder = {
events = {
WCGOV.5000 # New rulers get evil government if it's possible
WCGOV.6000 # Adds status_of_magic_3
WCGOV.6010 # Clear evil laws if you're not evil anymore
WCSDW.246 # Closes the Dark Portal
Expand Down Expand Up @@ -3154,8 +3155,8 @@ on_new_holder = {

# Warcraft
# HFP.42002 # Check titular Crusader titles
# HF.23700 # Apply proper succession laws tied to gender Doctrines when creating a new vassal. # It's CPU heavy and looks like it's not needed

HF.23700 # Apply proper succession laws tied to gender Doctrines when creating a new vassal.
HF.25510 # Clear loot province mission if province has fallen under your control.

# Warcraft
Expand All @@ -3165,7 +3166,7 @@ on_new_holder = {
# Warcraft
# JD.60204 # Rebel General's Empire continues temple names, triggers for any title with the uses_temple_names_by_script title flag

539 # Fix adventurers turning Tribal land Feudal # Warcraft Also changes government of new rulers including adventurers
539 # Fix adventurers turning Tribal land Feudal # Warcraft - Changes government of adventures

# Warcraft
# HF.49205 # Reconquista Beneficiary
Expand Down
2 changes: 2 additions & 0 deletions events/HF_religious_events.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14228,6 +14228,8 @@ character_event = {
############################################################


# Warcraft
# CPU heavy
#On_title_new_holder: check succession/women's status when creating new vassals.
#ROOT is the character, FROM is the title, FROMFROM is the old holder
character_event = {
Expand Down
15 changes: 6 additions & 9 deletions events/on_action_events.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6319,6 +6319,7 @@ diploresponse_event = {
}
}

# Warcraft - Changes government of adventures
character_event = { # Fix adventurers turning Tribal land Feudal
id = 539
hide_window = yes
Expand All @@ -6338,17 +6339,13 @@ character_event = { # Fix adventurers turning Tribal land Feudal
# There's feudals that can have no castles
government = feudal_government
# is_feudal = yes

# Warcraft
trait = adventurer

# Warcraft
trigger_if = { # Adventurers still have feudal_government when county is transferred
limit = { trait = adventurer }
num_of_count_titles = 1
NOT = { num_of_count_titles = 2 }
}
trigger_else = {
num_of_titles = 2
NOT = { num_of_titles = 3 }
}
num_of_count_titles = 1
NOT = { num_of_count_titles = 2 }

FROM = {
OR = {
Expand Down
48 changes: 40 additions & 8 deletions events/wc_government_events.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ character_event = {
}

immediate = {
log = "WCGOV.1000 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.1000 fired for [Root.GetBestName]"

any_demesne_title = {
limit = { prevs_title_can_has_laws_trigger = yes }
Expand Down Expand Up @@ -84,7 +84,7 @@ character_event = {
}

immediate = {
log = "WCGOV.1010 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.1010 fired for [Root.GetBestName]"

any_demesne_title = {
limit = {
Expand All @@ -99,7 +99,39 @@ character_event = {
recalc_succession = yes
}
}

### on_new_holder
# New rulers get evil government if it's possible
character_event = {
id = WCGOV.5000

is_triggered_only = yes
hide_window = yes

only_playable = yes

trigger = {
evil_public_religion_trigger = yes
num_of_titles = 2
NOT = { num_of_titles = 3 }
}

immediate = {
log = "(GOVERNMENT) WCGOV.5000 fired for [Root.GetBestName]"

if = {
limit = { religion = death_god }
set_scourge_government_effect = yes
}
else_if = {
limit = { religion = burning_legion_religion }
set_legion_government_effect = yes
}
else_if = {
limit = { religion = old_gods_worship }
set_black_pact_government_effect = yes
}
}
}
### on_new_holder on_new_holder_inheritance on_new_holder_usurpation ###
# Adds status_of_magic_3
character_event = {
Expand All @@ -121,7 +153,7 @@ character_event = {
}

immediate = {
log = "WCGOV.6000 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.6000 fired for [Root.GetBestName]"

FROM = { add_law = { law = status_of_magic_3 cooldown = no opinion_effect = no } }
}
Expand All @@ -148,7 +180,7 @@ character_event = {
}

immediate = {
log = "WCGOV.6010 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.6010 fired for [Root.GetBestName]"

FROM = { clear_evil_laws_effect = yes }
recalc_succession = yes
Expand Down Expand Up @@ -193,7 +225,7 @@ province_event = {
is_merchant_republic = yes
NOT = { has_character_flag = upcoming_elections_flag }
}
log = "WCGOV.7985 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.7985 fired for [This.GetBestName]"

set_character_flag = upcoming_elections_flag
character_event = { id = WCGOV.7990 years = 11 }
Expand All @@ -220,7 +252,7 @@ character_event = {
}

immediate = {
log = "WCGOV.7986 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.7986 fired for [Root.GetBestName]"

set_character_flag = upcoming_elections_flag
character_event = { id = WCGOV.7990 years = 11 }
Expand Down Expand Up @@ -288,7 +320,7 @@ character_event = {
}

immediate = {
log = "WCGOV.8000 fired for [Root.GetBestName]"
log = "(GOVERNMENT) WCGOV.8000 fired for [Root.GetBestName]"
primary_title = { save_event_target_as = target_republic }
capital_scope = { county = { save_event_target_as = target_city } }

Expand Down
Loading

0 comments on commit 777c3aa

Please sign in to comment.