-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Race Models #948
Merged
Merged
Static Race Models #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a static race for Hozen with 6 color variations.
Added 1 color variation of Jinyu including 1 color variation of their clothes.
…' into static-races
- Applied fixes. - Renamed files. - Added 6 more skin color variants and 3 more belt color variants.
ercarp
added
priority medium ❕
Shows priority
3D graphics 📐
Involves tweaking/adding 3D models
labels
Aug 20, 2022
Closed
- Added static models for Male and Female Mogu. - 1 set of armor for Female Mogu. - 1 set of clothes for Male Mogu. - 1 hairstyle for Male Mogu. - 5 skin color variants for Female Mogu. - 6 skin color variants for Male Mogu. - 5 hair color variants for Male Mogu. - 4 clothes color variants for Male Mogu. - 5 clothes color variants for Female Mogu.
- Added 6 skin color variations for Male Centaurs. - Added 3 skin color variations for Female Centaurs.
- Added 5 skin color variants for Harpy. - Commented out night_elven ethnicity for the Harpy culture as it was causing them to have eyebrows overlayed on top of the static model.
- Added 4 skin color variants for Dryads/Keepers of the Grove (2 Male, 2 Female). - Added 2 belt color variants for Keepers of the Grove. - Commented out night_elven ethnicity for the Harpy culture as it was causing them to have eyebrows overlayed on top of the static model.
- Added 5 skin color variants for Sethrak. - Added 4 armor color variants for Sethrak. - Fixed a spelling error in the female centaur file.
- Added 4 skin color variants for Magnataurs.
- Added 4 skin color variations for Wolvar.
- Added 8 skin color variations for Gorlocs.
- Added 8 skin color variations for Gnolls (4 Male, 4 Female). - Added 1 undead skin color variant for both Male and Female Gnolls.
- Added 2 skin color variants for Northrend Stone Giants.
- Added 1 color variation of Northrend Frost Giants. - Added 1 color variation of Northrend Frost Giant armor. - Renamed static_giant to static_stonegiant. - Added culture requirements for the Giant race_portrait_modifiers so the right culture uses the right type of model.
- Added 1 color variation of Northrend Fire Giants. - Added 1 color variation of Northrend Fire Giant armor. - Assigned the Northrend Fire Giant model to Koralon the Flame Watcher (ID: koralon).
- Added 1 color variation for Northrend Storm Giant. - Assigned the Northrend Storm Giant model to Emalon the Storm Watcher (ID: emalon).
- Added 2 more color variants to Northrend Stone Giants.
- Added 1 Northrend Stone Giant color variation. - Added 1 Northrend Stone Giant armor color variation. - Assigned a custom model to Gymer (ID: 440001).
- Added 4 skin color variants for Male Titan Watchers. - Added 6 skin color variants for Female Titan Watchers. - Assigned the correct color model to Loken (ID: 400501).
- Added a custom static model for Freya (ID: 400504). - Slight adjustment to Female Titan positioning.
- Added a custom static model for Thorim (ID: 400502).
- Added a custom static model for Thorim (ID: 400503).
- Added 9 skin color variants for Satyr.
- Added 5 Forst Nymph skin color variations (1 Male, 4 Female). - Added 4 Frost Nymph armor/hair color variations (1 Male, 3 Female).
- Added 8 skin color variations for Pandaren (4 Male, 4 Female). - Added 3 eye colors for both genders. - Added a belt model for both genders.
Forced to use different hairstyles with tusks if they cause clipping
- Removed dashes from code, replacing them with underscores. - Meshes (and some .dds files) still retain the dashes as it would be more complicated to fix them.
- Split wc_races.txt into 4 separate files: wc_static_beards.txt, wc_static_hairstyles.txt, wc_static_tusks_and_horns.txt and wc_static_races.txt. - Moved Tuskarr modifiers to the correct file. -
- Tried to give Tuskarr the portrait_hair shader and apply modifiers for the different hair colors, but it doesn't seem to be working properly.
Closed
- Added 4 Male Pandaren eyebrow types with 5 color variations.
- Added blind eyes for Male Tauren as well as a modifier to activate them when the character has the Blind trait.
- Made cyan and blue Female Mogu armor and skin color less bright.
Added tuskarr as ethnicity.
Cleaned up male pandaren hairs using shaders. Created pandaren ethnicities.
- Assigned values to Male Pandaren ethnicity hair colors. - Added gray Female Pandaren to the static_pandaren_white model so the white fur ethnicity doesn't spawn invisible Female Pandaren. - Added portrait_hair shader to Male Pandaren eyebrows.
- Created folders and sub-folders to make it easier to navigate.
- Desaturated the hair on malepandabeard-white.dds. - Made small adjustments to the hair color used by pandaren_red_ethnicity and pandaren_brown_ethnicity.
…' into static-races
…' into static-races
Eye color is used as additinal hair color for female pandaren. Female pandaren hairs take hair color. Removed extra entities.
Gaben1025
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
archavon
).toravon
) and Jokkum (ID:290000
).wc_race_portrait_modifiers.txt
so Hodirson culture Giants use the Frost Giant models and Gymerir use the Stone Giant models.koralon
).emalon
).440001
).400501
).400504
).400502
).400503
).400505
).Tuskarr aged 50 or above use gray hair colors.Edit: Reverted this change in 682a309 as it was also causing them to change their hairstyle entirely instead of just the color.210000
)210001
)210049
)210033
)2100888
)grummlebody2
due to how the mesh is structured.grummlebody1
) without the attached clothes.To-do list:
Static Models
Player Races
NPC Races
Other Tasks
Disable Hunchback visual effect for static models (see 6. under⚠️ Known issues).Fixed in 7c93a3d!Fix the bug causing human clothes to clip through Male Frost Nymphs under the age of 18 (see 13. under⚠️ Known issues).Fixed in 298cf0b!Assign Female Mogu armor properly so you don't get strange color combinations (see 1. under⚠️ Known issues).Fixed in 70d739a!Investigate and fix the bug causing some Female Pandaren to not use their⚠️ Known issues).Fixed in 6a5f5f8!static_eyes
(see 15. underInvestigate and fix the bug causing some Female Pandaren Children to not use their⚠️ Known issues).Fixed in 6a5f5f8!static_hairstyles
(see 16. underFind a way to restrict certain hairstyles being used by Tuskarr if their tusks are incompatible (or vice versa) (see 19. under⚠️ Known issues).Fixed in 3d4fe5c!If we manage to get heritage armor sets working, remember to update the Female Tauren model to use the version with 3D belt geometry (see 20. under⚠️ Known issues).Fixed in f047bd2!Remove the fourth Female Tauren horn color (it's a repeat of horn color 1).Fixed in 8f0d7c3!Adjust the blue Female Mogu armor'sFixed in 4d7ec9a!.dds
file a bit to make it darker. It looks a bit too "reflective".Create folders forAdded in 12c22cd!hairstyles
andbeards
inside thestatic_races\pandaren
directory and move all of the necessary files in their respective folders.Due to the way female Mogu models are structured, you can end up with some very strange-looking color combinations.Fixed in 70d739a!Click to expand
Some armor and skin textures look washed out. Not sure if this is a PDX issue or something that went wrong in the exporting process.Fixed in 8dc0d67!Click to expand
❗ Critical: The visual effect of Hunchback needs to be disabled for Giants, and perhaps for all the other static models as well (since it doesn't actually make them hunchbacked and most of the time it just cuts them off instead).Fixed in 7c93a3d!Click to expand
Theerror.log
is displaying a lot ofFailed to create material with shader (in gfx/FX/court_scene.shader) for mesh [gorlocShape] in gfx/models/portraits/static_races/giant/stonegiant.mesh
errors for all of the races I've added. Probably something wrong in either the.asset
file or the mesh names used in Blender.Some Northrend Frost Giants (This was caused by an incompatibility with Fullscreen Barbershop mod.frostgiant.asset
) have a pile of snow (?) in front of their model. This pile is not visible in Blender, so I'm not sure where it's coming from or how to delete it.Click to expand
Parts of the Northrend Fire Giant (Fixed in d27fd6d!firegiant.asset
) model are see-through when viewed from the side. This is not visible from the front.Click to expand
Click to expand
Critical: Some models have human eyeballs floating in front of them.This was caused by an incompatibility with Fullscreen Barbershop mod.Click to expand
Critical: Human clothes are clipping through some Male Frost Nymphs. This issue only happens with Male Frost Nymphs under the age of 18.Fixed in 298cf0b!Click to expand
@kaldrskegg noted that some of the models looked a bit "shinier" than they're supposed to, which may be due to the wrong texture color on one of the files. Worth looking into in case this is an issue.Fixed in 8dc0d67!Click to expand
❗ Critical: Some Female Pandaren have missing eyes.Fixed in 6a5f5f8!Click to expand
Some Female Pandaren Children are not using their hairstyles.Fixed in 6a5f5f8! Note: This may be worth adding back as a feature.Click to expand
Some Tuskarr hairstyles are incompatible with certain tusk types and thus cause clipping to occur.Fixed in 3d4fe5c!Click to expand
Female Tauren are using the wrong models currently as they lack the 3D geometry for the belt used by the Heritage armor. If we get the heritage armor working, they will need to be replaced with the correct version, but I'm not doing this yet in case we have to decide on an entirely different set of armor.Fixed in f047bd2!Click to expand
weight sum exceeds 255. The system can't guarantee that all entries can be picked.
errors inerror.log
relating tostatic_hairstyles
andstatic_hairstyles2
genes. I suspect this is because of the extreme amount of Female Pandaren hairstyle genes, so it may be worth thinking of a solution that doesn't require as many separate genes for their hair color variations.wc_race_portrait_modifiers.txt
and have gray hair (even at age 20).Tests:
wc
files inDocuments\Paradox Interactive\Crusader Kings III\logs\error.log
exceptportrait_decals.cpp:101
How to test:
1.5.0.1
and disable both Fate of Iberia and Royal Court.a. The position of the model. Are they too high or too low? Too small or too big?
b. Look for visual bugs and other errors and report them. (Make sure they aren't already reported under
c. Other general feedback and suggestions are also welcome.