Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kaldorei name and dynasty improvement and consolidation #1510

Open
wants to merge 21 commits into
base: feat/code/rtp-fixes-adaptation
Choose a base branch
from
Open

kaldorei name and dynasty improvement and consolidation #1510

wants to merge 21 commits into from
+1,252 −990

Conversation

edmund-h
Copy link
Contributor

@edmund-h edmund-h commented Oct 16, 2024 •
edited
Loading

Developer changelog:

  • removed dynasties/100000_night_elves.txt
  • moved all currently used night elf dynasties from that file to dynasties/128000_night_elves.txt
  • updated non-numbered dynasty names to use the format dynn_name for clarity and ease of searching
  • changed some dopey automatically generated nightelf names to cooler ones
  • ensure all kaldorei dynasty names are unique

@edmund-h edmund-h changed the title Feat/code/better kaldorei names kaldorei name and dynasty improvement and consolidation Oct 16, 2024
@edmund-h edmund-h marked this pull request as draft October 16, 2024 07:10
@edmund-h edmund-h marked this pull request as ready for review October 16, 2024 07:12
@edmund-h
Copy link
Contributor Author

@Grekopithikos please review again and see if your issues were addressed or if my subsequent work added more issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grekopithikos Grekopithikos Awaiting requested review from Grekopithikos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edmund-h