Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death Perks #1483

Draft
wants to merge 20 commits into
base: magic-2024
Choose a base branch
from
Draft

Death Perks #1483

wants to merge 20 commits into from

Conversation

robmart
Copy link
Member

@robmart robmart commented Sep 29, 2024

Changelog:

  • Added this thing.
  • Changed that thing.

Developer changelog:

  • Added this thing.
  • Changed that thing.

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

@Rimaka94
Copy link
Contributor

Rimaka94 commented Oct 1, 2024

Test Criteria

❌ Check that Necromancy perks are working as their Descriptions state.
🔶 Without debug_mode enabled, you have access to both Magic character interactions:

  • wc_magic_give_disease_interaction
  • wc_magic_epiemic_interaction

Marks:
✅ - working as expected
❌ - not working as expected
⚠️ - was unable to confirm if working as expected, needs more testing/confirmation
🔶 - may or may not be an issue, noted for your discretion

Note: I was not supposed to review perks yet, apologies. Dropping these notes here even though they aren't finished in case it helps at all.

In-depth Testing

🧟 Reanimator Branch

  • Frost Presence properly allows access to the Cryomancer tree.
  • ⚠️ Death Aura may be working properly, uncertain how to confirm if modifier is applied.
  • Eternal Suffering Seems to have a chance to give +1 to a pool which gives X amount of prowess upon being raised, however, the target does not ever gain any extra prowess from this upon being raised, after being executed. This may not be properly adding to the pool, or it may not be accessing it upon being raised.
    • 🔶 The description text for Torture's event is sometimes empty, see screenshot. I am unsure if this is due to this perk, or another issue.
    • ❌ Does not state that it allows you to be able to raise Banshees in perk description.
[SCREENSHOTS] Eternal Suffering torture event localization

image
image

  • Death Pact does not seem to be working. I was unable to get this to trigger on me and my knights when one of my other knights died in battle, after multiple attempts.
  • Fleshcrafting appears to be properly increasing the Base skills to raised undead.
    • ❌ Does not state that it allows you to be able to raise Abominations in perk description.

💀 Deathbringer Branch

  • Anti-Magic Barrier is properly adding scaling magic resistance.
    • 🔶 My feedback: This seems to be really difficult to get even a single point of magic resistance.
  • Death's Advance properly gives +5 prowess to your Knights, and is removed when they are no longer your Knight. Army movement speed properly applied.
  • Unholy Ground is properly giving +1% mana conductivity per every 5 counties with Death Corruption.
  • 🔶 Perk 8 missing.

🩸 Hematurge Branch

  • Blood Presence properly adds health boost/mana conductivity.
  • ⚠️ Unsure if Blood Siphon working properly, was unable to get this to trigger in a number of battles possibly due to the strict requirement. My character did not seem to ever be involved in personally killing any knights which is likely why, but my knights did under my character as Commander, and did not seem to trigger at all while my character was Maimed, and sometimes Wounded.
  • Vampiric Aura properly gives scheme resistance, but I'm assuming the less-chance-to-be-wounded is working as well as this is difficult to test.
  • Blood Gorged properly increases Mana Conductivity when injured.
  • Mark of Blood properly has a chance to apply Mark of Blood modifier for 30 days to enemy knights, after fighting.
  • 🔶 Perk 8 missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants