Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolation of Uldum and Pandaria #1439

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open

Isolation of Uldum and Pandaria #1439

wants to merge 26 commits into from

Conversation

Malicos
Copy link
Contributor

@Malicos Malicos commented Sep 8, 2024

Changelog:

  • The Shroud of Uldum and Mists of Pandaria now block interactions with outsiders and vice versa.

Developer changelog:

  • All interactions now have checks whether characters are isolated
  • Added on_actions regulating isolation events
  • Added illustrations for Uldum and Jade Forest in Pandaria
  • Localized events regulating the isolation (copypasted from GoA1 rendition)
  • Simplified isolation trigger (thanks Robmart)

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

  • Play as any character in Uldum and Pandaria and verify if they cannot interact with characters beyond.
  • Play as any character outside of Uldum and Pandaria and verify if they cannot interact with characters within.
  • Wait until 610 for the event where Shroud of Uldum is lifted
  • Wait until 613 for the event where Mists of Pandaria are lifted
  • Alternatively, write event isolation.1 or event isolation.2 in console to manually trigger the events lifting isolation
  • Verify if Pandaria and Uldum can interact with outsiders and vice versa

@Malicos Malicos added new feature ⭐ Involves adding new feature that affects game lore 📚 Comes from lore localisation 📄 This issue or pull request supposes localization changes vanilla modification 🍦 Involves vanilla modifications labels Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation 📄 This issue or pull request supposes localization changes lore 📚 Comes from lore new feature ⭐ Involves adding new feature that affects game vanilla modification 🍦 Involves vanilla modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants