Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seducers Tradition #1322

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

Seducers Tradition #1322

wants to merge 24 commits into from

Conversation

Grekopithikos
Copy link
Contributor

@Grekopithikos Grekopithikos commented Jan 6, 2024

Changelog:

  • Added the Seducers tradition. As the name suggests, it helps with seduction.
  • Added the Seducers tradition to the Sayaadi culture.
  • The Sayaadi race can do two seduction schemes at a time

Developer changelog:

  • For some reason there are more files in the Files changed part than there are supposed to. This is likely because the pr is old. I've tried rebasing it on dev but it didn't change anything. Whatever files aren't related to the pr are part of the dev branch and thus are safe to ignore.

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

@helloruhe helloruhe added this to the 0.5 Release Alpha milestone Jan 7, 2024
@Grekopithikos Grekopithikos self-assigned this Jan 7, 2024
@Grekopithikos Grekopithikos added the cultural 🎓 Involves cultural mechanics label Jan 7, 2024
@helloruhe helloruhe changed the base branch from master to dev August 15, 2024 14:38
@helloruhe
Copy link
Contributor

@Grekopithikos what needs to be done for this to be merged ?

@Grekopithikos
Copy link
Contributor Author

@Grekopithikos what needs to be done for this to be merged ?

For someone to test it

@Rimaka94
Copy link
Contributor

  1. SCHEME_PRESTIGE_LEVEL_MODIFIER needs localization
In-game example

image

  1. Completing Seduction schemes successfully as Sayaad/Sayaadi with Seducers tradition is not granting Prestige nor Renown, only Piety.

  2. Failing a Seduction scheme as Sayaad/Sayaadi with Seducers tradition is not inflicting stress on scheme failures.

In-game example

image

  1. When hovering over the Predicted Success Chance I don't see the +15% for the All Sayaadi Characters 'Seduce Scheme Power +15%' from Seducers tradition maybe it's just not showing in the tooltip?

@Raged50
Copy link
Contributor

Raged50 commented Aug 17, 2024

Hey Grek

Last time I reviewed this I wasn't happy with the current implementation of the Seducers tradition. Namely, I mentioned that the double prestige gain from seducing was already overpowered because tribal rulers can use it to indefinitely upkeep a large MAA army that is funded by seducing king~ tier rulers.

What you've designed currently is more applicable to the race trait itself rather than a culture, and I don't have any issues with the sayaadi race being able to do 2 seduction schemes at the same time.

I would suggest you have a look at the vanilla CK3 traditions and go back to the drawing board and revisit how this can be better implemented, and my suggestions might look something like the following:

-15 Same culture opinion for Content trait
+15 Same culture opinion for Lustful trait
-30 Same culture opinion for Celibate trait
+10 Seduction Scheme success chance
+10 Hostile Seduction Scheme success chance
Lustful trait is more common
+30 Same culture opinion for Seducer trait

You could also look at implementing something like all holdings have increased tax but have a heavily reduced plague resistance modifier, or have a decision to create a unique building or allow seducers to create their own building.

For now in its current design I do not support the above concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cultural 🎓 Involves cultural mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants