build: stop dependabot proposing YamlDotNet 18.x - #340
Merged
Conversation
Dependabot opened #339 to take YamlDotNet from 17.1.0 to 18.1.0 within minutes of #327 landing. That bump is not viable and #327 documented why inline, but a comment in `Directory.Packages.props` does not stop the bot re-proposing it. 18.1.0 breaks `BattleScribeSpec.TestKit` in the `lib/battlescribe-spec` submodule: its `SpecLoader` static initializer throws, and all 362 passing conformance specs stop loading. Central package management applies our version to the submodule's projects too, and the TestKit is built against the 17.x API. Ignoring `>=18.0.0` until battlescribe-spec itself moves to 18.x, mirroring the existing FluentAssertions rule. Tracked in #330. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot opened #339 to take YamlDotNet from 17.1.0 to 18.1.0 within minutes of #327 landing. That bump is not viable, and while #327 documented why inline, a comment in
Directory.Packages.propsdoes not stop the bot re-proposing it.18.1.0 breaks
BattleScribeSpec.TestKitin thelib/battlescribe-specsubmodule — itsSpecLoaderstatic initializer throws, and all 362 passing conformance specs stop loading:Central package management applies our version to the submodule's projects too, and its TestKit is compiled against the 17.x API.
Ignoring
>=18.0.0until battlescribe-spec itself moves to 18.x, mirroring the FluentAssertions rule added in #327. Tracked in #330.Closes #339.
🤖 Generated with Claude Code