Skip to content

chore(deps): bump utils-rs to 74ff898 - #339

Open
mario-reown wants to merge 2 commits into
mainfrom
chore/bump-utils-rs
Open

chore(deps): bump utils-rs to 74ff898#339
mario-reown wants to merge 2 commits into
mainfrom
chore/bump-utils-rs

Conversation

@mario-reown

@mario-reown mario-reown commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Lockstep bump so wc_metrics unifies with rs-relay, which is moving to utils-rs WalletConnect/utils-rs#34 (AWS legacy hyper-0.14/rustls-0.21 client dropped, maxminddb 0.27, parquet 59). Two revs of wc_metrics in one graph break the Enum label trait for OperationName.

wcn uses wc with default-features = false (alloc, collections, future, metrics), none of which changed. Cargo.lock: only the utils-rs crates move.

Also: ci cargo-deny job used check license, which cargo-deny-action@v2 now rejects (invalid value 'license'); fixed to check licenses. The job only runs when Cargo.toml changes, so this was latent.

Known unrelated red: bump-version fails at checkout because the org secret RELEASE_PAT (last rotated 2025-09-02) has expired — needs an org admin to rotate.

Verified: cargo check --workspace --all-targets clean.

Keeps wc_metrics on the same rev as rs-relay, which needs utils-rs #34
(AWS legacy TLS client dropped, maxminddb 0.27, parquet 59).
@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown

Claude finished @mario-reown's task in 1m 16s —— View job


Review Complete

  • Read changed files
  • Analyze dependency updates
  • Check for external URLs and security concerns
  • Complete review

Issues Found

⚠️ Undocumented Dependency Change
File: Cargo.lock:2182
Issue: darling_core dependency on syn downgraded from 2.0.106 to 1.0.109 (major version regression)

PR description claims "Cargo.lock: only the utils-rs crates move" but syn dependency also changed. This major version downgrade (2.x → 1.x) should be:

  • Documented in PR description
  • Verified as intentional
  • Tested to ensure no compatibility issues with code using syn macros

Recommendation: Verify if this syn downgrade is intentional and whether it causes any compilation or runtime issues with derive macros or procedural macros in the project.


cargo-deny-action@v2 now rejects 'check license'; the job only runs when
Cargo.toml changes, which is why this stayed hidden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant