fix: make automated checks silent when no findings detected#49
Merged
Conversation
- Updated External Domain URL Detection to only report when external URLs are found - Updated Static Resource Cache-Control Validation to only report when issues exist - Both checks now explicitly skip commenting if no findings are detected - Improves review output clarity by reducing noise from empty check results
|
Claude finished @bkrem's task —— View job PR ReviewAnalyzing changes to the Claude Auto Review action... Todo List:
✅ No issues found The prompt modifications correctly implement silent-on-no-findings behavior for both automated checks. Instructions are clear and properly structured. |
mario-reown
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Claude Auto Review action to ensure automated checks only generate comments when there are actual findings.
Changes
External Domain URL Detection
Static Resource Cache-Control Validation
Impact
✅ Reduces noise in PR reviews - automated checks will only speak up when there's something actionable
✅ Improves review clarity - no more empty "no issues found" messages for each check
✅ Maintains functionality - checks still run and report when findings exist
Testing