Skip to content

chore: condense project_context and remove backticks to fix Claude review action#46

Merged
bkrem merged 2 commits intomasterfrom
devin/1761584462-fix-project-context-backticks
Oct 27, 2025
Merged

chore: condense project_context and remove backticks to fix Claude review action#46
bkrem merged 2 commits intomasterfrom
devin/1761584462-fix-project-context-backticks

Conversation

@devin-ai-integration
Copy link
Contributor

chore: condense project_context and remove backticks to fix Claude review action

Summary

This PR fixes a critical bug in the Claude Auto Review GitHub Action where backticks and shell-interpretable syntax in the project_context were being executed as bash commands, causing the action to fail. The fix involves:

  1. Condensed project_context from ~150 lines to ~30 lines, focusing only on essential PR review context (repository purpose, primary entry points, key conventions, security expectations, and reviewer focus areas)
  2. Removed all shell-interpretable syntax including backticks, $(...), $VARIABLE, and inline code formatting that bash would interpret as commands
  3. Added warning comment in the workflow file to prevent future issues
  4. Added warning in README documenting the limitation and guidance for future users

The original failure can be seen in this GitHub Actions run where shell interpretation errors occurred (e.g., "command not found", "syntax error").

Review & Testing Checklist for Human

  • Verify the Claude review action runs successfully on this PR - This is the most critical test to confirm the fix works end-to-end
  • Review the condensed project_context (lines 38-69 in .github/workflows/claude-review.yml) to ensure no essential information was lost that would significantly degrade review quality
  • Consider whether the warning in the README (line 254 in claude/auto-review/README.md) is clear enough to prevent future contributors from reintroducing shell-interpretable syntax

Recommended Test Plan

  1. Wait for this PR's Claude review action to complete successfully (should not show shell interpretation errors)
  2. Review the actual Claude review comments (if any) on this PR to assess if the condensed context is sufficient
  3. If review quality seems degraded, consider what specific context should be added back (without shell-interpretable syntax)

Notes

  • The project_context content reduction is intentional - it removes verbose explanations and code examples that contained shell-interpretable syntax while retaining high-level guidance
  • The underlying architectural limitation (project_context inserted into double-quoted bash string) remains, so future editors must be careful
  • Trailing whitespace was automatically cleaned by pre-commit hooks

Link to Devin run: https://app.devin.ai/sessions/5f55b97731404af2a46641956ca32880
Requested by: Ben Kremer (ben@reown.com) / @bkrem
Slack thread: https://reown-inc.slack.com/archives/D08N55XF1QQ/p1761584275689479?thread_ts=1761584275.689479

…view action

- Condensed project_context from ~150 lines to ~30 lines focusing on key PR review context
- Removed all backticks and shell-interpretable syntax that were causing bash execution errors
- Added warning comment in workflow file about shell interpretation
- Added warning in README about project_context limitations
- Fixes GitHub Actions run failure where backticks were interpreted as command substitution

Co-Authored-By: Ben Kremer <ben@reown.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@bkrem bkrem merged commit 29d54ba into master Oct 27, 2025
@bkrem bkrem deleted the devin/1761584462-fix-project-context-backticks branch October 27, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant