[CI] Update ci.yml to use "self-hosted" m1 runner #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
force-pushed
the
feat/ci/self-hosted-runners
branch
from
802035e
to
2b624d1
Compare
radeknovis
changed the title
radeknovis
force-pushed
the
feat/ci/self-hosted-runners
branch
2 times, most recently
from
dad52c9
to
4f0f335
Compare
radeknovis
reviewed
Jul 28, 2023
| Listing(id: "1", name: "Sample App", homepage: "https://example.com", order: 1, imageId: "1", app: Listing.App(ios: "https://example.com/download-ios", mac: "https://example.com/download-mac", safari: "https://example.com/download-safari"), mobile: Listing.Mobile(native: nil, universal: "https://example.com/universal")), | ||
| Listing(id: "2", name: "Awesome App", homepage: "https://example.com/awesome", order: 2, imageId: "2", app: Listing.App(ios: "https://example.com/download-ios", mac: "https://example.com/download-mac", safari: "https://example.com/download-safari"), mobile: Listing.Mobile(native: "awesomeapp://deeplink", universal: "https://awesome.com/awesome/universal")), | ||
| ]) | ||
| XCTAssertEqual(sut.wallets.map(\.id), ["1", "2"]) |
There was a problem hiding this comment.
This is here because I uncovered an issue running this test multiple times on the same simulator due to the fact we are now saving recent wallets to userDefaults so I made sure we are checking only relevant information
llbartekll
approved these changes
Aug 1, 2023
radeknovis
force-pushed
the
feat/ci/self-hosted-runners
branch
from
a91d51d
to
a5f684a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence