Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notify] Sqlite lock #1215

Merged
merged 4 commits into from
Nov 8, 2023
Merged

[Notify] Sqlite lock #1215

merged 4 commits into from
Nov 8, 2023

Conversation

flypaper0
Copy link
Contributor

Description

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

llbartekll
llbartekll reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure I understand how it suppose to work

@alexander-lsvk
Copy link
Contributor

Regarding locks: I have them implemented in the NativeSocket branch, but I used UnfairLock cuz they are faster. You can check the solution, maybe you can just reused them if you don't have any constraints to use NSLock specifically.

https://github.com/WalletConnect/WalletConnectSwiftV2/blob/1ab4dbef32e54c89e1c235b0f4fe42cdb3024815/Sources/WalletConnectRelay/WalletConnectSocketClient/UnfairLock.swift

@flypaper0 flypaper0 merged commit 446c149 into develop Nov 8, 2023
8 checks passed
@flypaper0 flypaper0 deleted the feature/sqlite-concurrency branch November 8, 2023 12:49
@flypaper0 flypaper0 mentioned this pull request Nov 8, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flypaper0 @alexander-lsvk @llbartekll