Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notify] Use gm project id for explorer #1196

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

flypaper0
Copy link
Contributor

No description provided.

@flypaper0 flypaper0 temporarily deployed to internal October 24, 2023 06:58 — with GitHub Actions Inactive
@llbartekll llbartekll self-requested a review October 24, 2023 13:29
@@ -10,7 +10,7 @@ public struct NotifyClientFactory {
let groupKeychainService = GroupKeychainStorage(serviceIdentifier: groupIdentifier)

return NotifyClientFactory.create(
projectId: projectId,
explorerProjectId: projectId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what explorerProjectId means?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on prod it's just a projectID correct?

@flypaper0 flypaper0 temporarily deployed to internal October 24, 2023 13:41 — with GitHub Actions Inactive
@flypaper0 flypaper0 merged commit b803c15 into develop Oct 24, 2023
8 checks passed
@flypaper0 flypaper0 deleted the feature/gm-project-id-var branch October 24, 2023 13:51
@flypaper0 flypaper0 mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants