Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notify] SIWE Spec change #1172

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[Notify] SIWE Spec change #1172

merged 2 commits into from
Oct 11, 2023

Conversation

flypaper0
Copy link
Contributor

Description

  • siwe message updated according specs
  • encoding null app for watch subscription request jwt

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@flypaper0 flypaper0 temporarily deployed to internal October 10, 2023 15:30 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 10, 2023 15:43 — with GitHub Actions Inactive
@flypaper0 flypaper0 linked an issue Oct 11, 2023 that may be closed by this pull request
[Notify Beta.1] Update SIWE message #1161
Closed
@flypaper0 flypaper0 merged commit c29b11e into develop Oct 11, 2023
8 checks passed
@flypaper0 flypaper0 deleted the feature/siwe-spec-change branch October 11, 2023 15:11
flypaper0 added a commit that referenced this pull request Oct 12, 2023
@flypaper0
Revert "Merge pull request #1172 from WalletConnect/feature/siwe-spec…
50b99f7 
…-change"

This reverts commit c29b11e, reversing
changes made to 6cb2405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@alexander-lsvk alexander-lsvk Awaiting requested review from alexander-lsvk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Notify Beta.1] Update SIWE message
2 participants
@flypaper0 @llbartekll