[Verify, Echo] Fallback to .org #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeknovis
approved these changes
Aug 9, 2023
| case dataTaskError(Error) | ||
| case noResponse | ||
| case badStatusCode(Int) | ||
| case responseDataNil | ||
| case jsonDecodeFailed(Error, Data) | ||
|
|
||
| public static func ==(lhs: HTTPError, rhs: HTTPError) -> Bool { |
There was a problem hiding this comment.
nit: I wonder if you could use if case let pattern matching instead of conforming to Equatable. When I'm not sure how to write it I use this website https://fuckingifcaseletsyntax.com/ :D
There was a problem hiding this comment.
But the enum still has to be equitable for this, no? 🤔
There was a problem hiding this comment.
Not necessarily if case let works in same way as switch, and you don't need Equatable for the switch.
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
Closed
llbartekll
reviewed
Aug 14, 2023
Comment on lines
37
to
49
| return try await originVerifier.verifyOrigin(assertionId: assertionId) | ||
| do { | ||
| return try await originVerifier.verifyOrigin(assertionId: assertionId) | ||
| } catch { | ||
| if (error as? HTTPError) == .couldNotConnect && !fallback { | ||
| fallback = true | ||
| originVerifier.verifyHostFallback() | ||
| return try await verifyOrigin(assertionId: assertionId) | ||
| } | ||
| throw error | ||
| } |
There was a problem hiding this comment.
same here could we move the implementation from the client?
There was a problem hiding this comment.
@llbartekll done
it's still in the client 😅
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
|
@llbartekll done |
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
llbartekll
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence