Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflections #273

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Fix reflections #273

merged 2 commits into from
Jan 18, 2025

Conversation

nnichols
Copy link
Member

Proposed Changes

  • Fixed
    • Enabled *warn-on-reflections* globally.
    • Fixed outstanding reflection.

Pre-merge Checklist

  • Read and agree to the Contribution Guidelines and Code of Conduct
  • Write new tests for impacted functionality
  • Update the CHANGELOG and increment version
  • Update the README and other relevant documentation

@nnichols nnichols requested a review from a team as a code owner January 18, 2025 00:18
@nnichols nnichols requested review from Dareknotderek and removed request for a team January 18, 2025 00:18
@WallBrewBot WallBrewBot added documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD dependencies Updates to application dependency files source code Updates to the application or library source code clojure Clojure source code clojurescript ClojureScript source code labels Jan 18, 2025
@nnichols nnichols merged commit 9289658 into master Jan 18, 2025
12 checks passed
@nnichols nnichols deleted the fix-reflections branch January 18, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dareknotderek Dareknotderek Awaiting requested review from Dareknotderek Dareknotderek is a code owner automatically assigned from Wall-Brew-Co/wall-brew-developers

Assignees
No one assigned
Labels
clojure Clojure source code clojurescript ClojureScript source code dependencies Updates to application dependency files documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD source code Updates to the application or library source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnichols @WallBrewBot